From: Markus Elfring <Markus.Elfring@web.de>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Rob Herring <robh@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
amitrkcian2002@gmail.com,
Bernhard Frauendienst <kernel@nospam.obeliks.de>,
git@amd.com
Subject: Re: [PATCH v12 3/3] mtd: Add driver for concatenating devices
Date: Wed, 5 Feb 2025 17:23:33 +0100 [thread overview]
Message-ID: <ffd401b5-9b0d-4339-befd-19b704479ade@web.de> (raw)
In-Reply-To: <20250205133730.273985-4-amit.kumar-mahapatra@amd.com>
I suggest to improve implementation details another bit at a few source code places.
Examples:
…
> +++ b/drivers/mtd/mtd_virt_concat.c
> @@ -0,0 +1,254 @@
…
> +static int mtd_virt_concat_create_item(struct device_node *parts,
> + unsigned int count)
> +{
+ struct mtd_virt_concat_node *item __free(kfree) = kzalloc(sizeof(*item), GFP_KERNEL);
…
> +int mtd_virt_concat_node_create(void)
> +{
…
+e_nomem:
+ ret = -ENOMEM;
+put_parts:
+ of_node_put(parts);
> +destroy_items:
> + mtd_virt_concat_destroy_items();
> +
> + return ret;
> +}
…
Regards,
Markus
next prev parent reply other threads:[~2025-02-05 16:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 13:37 [PATCH v12 0/3] mtd: Add support for stacked memories Amit Kumar Mahapatra
2025-02-05 13:37 ` [PATCH v12 1/3] dt-bindings: mtd: Describe MTD partitions concatenation Amit Kumar Mahapatra
2025-02-11 21:29 ` Rob Herring
2025-02-12 8:25 ` Miquel Raynal
2025-02-12 16:06 ` Rob Herring
2025-02-12 16:18 ` Miquel Raynal
2025-02-18 21:39 ` Rob Herring
2025-02-19 8:36 ` Miquel Raynal
2025-02-05 13:37 ` [PATCH v12 2/3] mtd: Move struct mtd_concat definition to header file Amit Kumar Mahapatra
2025-02-05 13:37 ` [PATCH v12 3/3] mtd: Add driver for concatenating devices Amit Kumar Mahapatra
2025-02-05 16:23 ` Markus Elfring [this message]
2025-03-18 15:53 ` Miquel Raynal
2025-03-19 6:17 ` Mahapatra, Amit Kumar
2025-03-19 8:21 ` Miquel Raynal
2025-04-30 14:18 ` Mahapatra, Amit Kumar
2025-05-12 10:01 ` Miquel Raynal
2025-05-13 14:45 ` Mahapatra, Amit Kumar
2025-05-16 14:06 ` Miquel Raynal
2025-05-21 6:13 ` Mahapatra, Amit Kumar
2025-05-26 8:10 ` Miquel Raynal
2025-05-26 14:27 ` Mahapatra, Amit Kumar
2025-05-26 14:39 ` Miquel Raynal
2025-05-26 15:01 ` Mahapatra, Amit Kumar
2025-05-27 8:21 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd401b5-9b0d-4339-befd-19b704479ade@web.de \
--to=markus.elfring@web.de \
--cc=amit.kumar-mahapatra@amd.com \
--cc=amitrkcian2002@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=kernel@nospam.obeliks.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®