From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1C53194C95 for ; Mon, 4 May 2026 07:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777878399; cv=none; b=T+SyBS2w2M8vJCn27b84NScT+FQ1jjfvBh2u1X3qRLoToy6xxOM4IMCSZ6qDcQHIJoKICyVO9V1njN9bUD5qpGSGMWvmqR5FX9Cx0v1DFBbFZ12fMoMtgZDf0r857Wtsp7G8kjyjc+X2jypVTwWmcC0LFPfsDVHYeGivtX9dD5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777878399; c=relaxed/simple; bh=95gzVVmt+pw2w1ewq3IbkhXHmC7ClllvwdDzT6KAVs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BwS206x0x01LQSjBROnMuCfPrXYZouIgUvyFOjzdASmWyLeGNFBKJJjFAUosQsbqNu2PtrB5Yr28mJofvem2tWUOuz+WeLSL4czMxhRCJPjW9UsHr2b39yO7rEC1Thp8Huc3v3TbParoaVC95mCElWLsrtl8mfRbvsxBveZpviw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f7L2ScIl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VQAOH+j3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f7L2ScIl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VQAOH+j3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6446DNCQ3505231 for ; Mon, 4 May 2026 07:06:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KCWGn2uzwamB2rWwC+/Q9KFgMXFAeWM7XXqwwI7+OpQ=; b=f7L2ScIlzgUsnpyR VfiAY+btzU06ihT9wy6Bci1LzEHY7s61RGfpJ53JPMrFVFHpQVYR0oH/oBskIZ/8 25xCyzCnD/cRUoXJOeGts5uvW/GmGxo5aUwYCkgiwW38Sjqu6IoUAEETcNX1Hzg9 1YJw0HrXG/7OYfbWR1rOfgSsgILeAPMSewfoADdhDSt0uklFxOYgokZW5kS1f25K n3vybFNrOew5sK58srARoN8cQ8hGiNb153gQ2HCizr5h2IJQmiu8fVE95XDvcpye A0DLHw+Vup9CbRNvAB16k+rvDmRWXr64APNXIxpTjx/1wizdOLnB+Oht5LNYFGwG Y/leVA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dw6yfd02e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 04 May 2026 07:06:37 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3651991d0bcso2804402a91.0 for ; Mon, 04 May 2026 00:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777878396; x=1778483196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KCWGn2uzwamB2rWwC+/Q9KFgMXFAeWM7XXqwwI7+OpQ=; b=VQAOH+j3S5KNAlq2IPA77tRDfC5TWL+kyR5ykIRP2cayFvbl+vcOtGhPvQynjzgJ1B Ol6enwWEr3kA/9qqS6TKluwAzLvT68SG7buLiH8CLt7HPGOsOocW21LqQjL2iFu1i30R /G1mSewzTjV8Af89AE4teJ3CwIl6jKifaYtZDzMkzH/pRK9X808zHjVUBcVKxVmX4diq ITWb/VvmlCiyqPifbRpay+Elzwn0SjSBWCVpMBFWNKBCdoCCePGJLmGAtr/anaU9ZiEm /W0igFOsKI33E2nrfrkXYhh2oNXFeZPZRia9JlohCfDanuLGwINVi9fEun7dVy3iDlOx t+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777878396; x=1778483196; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KCWGn2uzwamB2rWwC+/Q9KFgMXFAeWM7XXqwwI7+OpQ=; b=TpjD9BLaDggjvbfpy5QC1ZJEvuDJvrpyL4Q04igd64jBgoH684EqatW/5GjGHeOPK1 wk2qG/xc3hBI7zF0oAkJaI44Ex34KAZDRA2BRuSmBLfYQDUo8BQoYIzhS5/0y/ejkd3l 2Nrzvo6rIvy8HoF8scG4aNb5K7RdWinYs5S15fwQ6ANtEDbvXM/8Oty+8Qd+c4dMNaU4 VwWb6ms09ik2qDWtuSWHhq7EL0SpOfDtdM6g+SeXNOFzZz6cBWXMmUhC+2SOYoNQHMcw 9fe9GE2LJera7AhwTz3/YE59P5hrxi0tGooX999+R8tNhgH10l8AHxqQ8jAdDBhhuUsn 7/FA== X-Forwarded-Encrypted: i=1; AFNElJ99sT9tS7hqvD289dL1KorknqNhhA/Exb1Lg1YWuiV2kuS+8rkfPWJo5MdcEvtoeS4vvXSNbdnmu58DLgo=@vger.kernel.org X-Gm-Message-State: AOJu0YwD7z/U4l8DSpFnH/qnMicgt9LNrI9t67OtE+vJ+KZegeTrA90F 2+I2EuRf2QKs2zCzcIRvS+Skm5So7xC4Yd+OoTfIajZ3cN0OzOoMvC+1LRl/B3G2PT8boyL+bwb 9yoRYC3q+/wRBlt8u9AazPYIBkiXiqj3sRwpqk5nQs+QwI2VpStgacb0+WFg1Hs0s2pA= X-Gm-Gg: AeBDievgVnR1cP1kzVfiYpNJcrdiQbeHaNJFn7IG07FxIyf+w3rpAOInv0M71KJ6l91 ZqF+hLobUlpRVDV5PBUCBR/4skAXF0wiTp8f3Fh34DQmvfgNehIcHdSGdhHBWl6cyrDbDIRYSxh Pf85DwK3ZhylNdyV+FS2HZ5bjXCCtIosbe2qkBxucRFgdyHt2x65bN0EWlzxAJhJvjfkI9q4UcZ 95sYECJtCplDzWskvJgYAZ09mAN2luEh6mLYG1vfwrxdz3lL3OC3HpOljjc2KJlwwsXDv+yOlGP yMuXZDe+lP1qGHVg/FLTFTePCcbMGrjD2/0Xw3Bal4RICO24daK2TUisENndM4iepBv0yNcUdNl uK+J3e234WUkz8FGaJ3R2SwW6jc+iKU+yJnpS+GJsIKpdRR1qGpiMIY4YKD2TsBn+3g== X-Received: by 2002:a17:90b:35cf:b0:35b:e4f8:7b2b with SMTP id 98e67ed59e1d1-3650ce8ef42mr8906525a91.18.1777878396364; Mon, 04 May 2026 00:06:36 -0700 (PDT) X-Received: by 2002:a17:90b:35cf:b0:35b:e4f8:7b2b with SMTP id 98e67ed59e1d1-3650ce8ef42mr8906494a91.18.1777878395886; Mon, 04 May 2026 00:06:35 -0700 (PDT) Received: from [10.92.193.136] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364be00b175sm12883779a91.9.2026.05.04.00.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 00:06:35 -0700 (PDT) Message-ID: Date: Mon, 4 May 2026 12:36:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PCI: qcom: Add D3cold support To: Steev Klimaszewski Cc: bhelgaas@google.com, bjorn.andersson@oss.qualcomm.com, jingoohan1@gmail.com, jonathanh@nvidia.com, kwilczynski@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, robh@kernel.org, will@kernel.org References: <20260504041407.289464-1-threeway@gmail.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20260504041407.289464-1-threeway@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Fc6kHcTcvdXk9kFswKpS7VSoS2ST9rQF X-Proofpoint-GUID: Fc6kHcTcvdXk9kFswKpS7VSoS2ST9rQF X-Authority-Analysis: v=2.4 cv=QY5WeMbv c=1 sm=1 tr=0 ts=69f8457d cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=oJpzRAQ81oZ_FtZBIQYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA0MDA3NCBTYWx0ZWRfXyrXtY81SLkpa OzCjyIkyqp9JI42ctPnuZ+pjxbkS3Lud84VJnlIcpyh4h/XjcTKoPR7H8bZJFMvgz4sLriOwFIO wbvB+/QYiz/RPi2Xb1btL8fMSIIUdJMn+JFd1T6RCr+8L2l1ekfbM1IiiUA4ovrBYNVYoi8ZZUh CUZf+gUqKcfLTUucHO5q6N7I8o3rrczQPz7bvcGuF6mQ81UkR5JozTyzZz/WgdFUXQuu+Z2Lop1 Ww+eRZNFT0PI/gW2IvSzXNambL2wSFJRJnMtEM4So45Yvqlr9qyYqgX+2Wal8L1BQ4KqgGneT6W sqf5DqYwaIxE7s6AdxtaWwrDtN0/ercMNvLu2xIbb6gLo7IQmCVV6fdgJ8KwWm97YgzywnaPrXL DqtltqEeXW3KkKqkXlvs4dq45gDv+PdKRRNJDLDxMJWT0FU52vSNfyZBwMnNkROpc+fLSJDhsZo uMl6jzkuXjM0JocbatA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605040074 On 5/4/2026 9:44 AM, Steev Klimaszewski wrote: > On Sun, May 3, 2026 at 10:37 PM Krishna Chaitanya Chundru wrote: >>> v4 of this patchset *boots* along with Mani's patchset, however, v5 does not, >>> and unfortunately, the machine does not seem to get to a point where I can even >>> get logs from it.  Do you know what I might be missing?  I have *not* attempted >>> to remove the nvme drive and boot off USB to test it. >> This series, will not have any impact on the boot, this series comes in to the >> picture only in case >> of suspend and resume. can you share your platform details and kernel you are >> booting with. > Oddly, it seems to, because if I simply go back to v4, the system boots. I'm > using a 7.0 kernel on the Thinkpad X13s (SC8280XP). The sources are at > https://github.com/steev/linux/tree/lenovo-x13s-linux-7.0.y (with the v5 > applied). PCIE_QCOM is built-in to the kernel. Not sure what other information > is needed. Hi Steev, I made mistake in re basing the code, can you try below and see if that fixes your issue. I will send this in next patch series. --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1327,7 +1327,7 @@ static enum dw_pcie_ltssm qcom_pcie_get_ltssm(struct dw_pcie *pci)         struct qcom_pcie *pcie = to_qcom_pcie(pci);         u32 val; -       if (pcie->cfg->ops->ltssm_enable) +       if (pcie->cfg->ops->get_ltssm)                 return pcie->cfg->ops->get_ltssm(pcie);   - Krishna Chaitanya. >> - Krishna Chaitanya. >>> -- steev