From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66D12E11AA; Tue, 3 Feb 2026 22:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770157723; cv=none; b=AS6FiOmBGOWrweW0hiEJgIPV9NEPEW0dIhpzQ0L/p8NS369R5rRjb2dZQJ+/6nljtkyDEGfSMJ0oHQ6TnZah2zHSFMDnganTmCoI44A9B+zzii4Eluoxt8YHPzaShBZwz0wLVb/hLY956wtzdG4zJ97MsKnN3Y2NbdAJEGV2uxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770157723; c=relaxed/simple; bh=l4RNNUHLX/moEp8ihVd7H0HLeHfSNwK7YcCqcN1/+3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ja8xxTMGYbLTck2C6DhhBFylwXylRPAZrCXe18FyFURlJ+pdmTyBLuHEKJ8MhW7qVr9C1g0E+2z2/YKtqkfwezG5oDvdMxbfWiG6HQ/CEXkiwscL08VEGzoZVsfhvowmgCaOK5z45hzaUEKIMLRm4Pqzid67FofIC9VS7Yenw4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=o2mZa+JW; arc=none smtp.client-ip=80.241.56.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="o2mZa+JW" Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4f5J6X4jHQz9tjW; Tue, 3 Feb 2026 23:28:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1770157716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f1o9nsF9YwvZWpGmMUWR2zMYlmkS0PV7dw8KDeOPo2k=; b=o2mZa+JWIjUtAWsm8GylAKwi0CRpo3hyrPxMhO7TDg4u1bN5fTRifX4Uor/7P0crcyCQGy fwS3CzFz2uOBprnGT3dtkrxcRfSys4g+KnEq5mlQXK9OAAeP/wyRI1abrsAfm4aDGcNQVK wDfTAKg795QMinjfaja7WDNYt142oGAR/kGNbFLD0Ri0SP0xX61MM0CJGByNn4EKxMB4L8 hDNGhp6nqMObwR2VXqOQixA9hVygnyijRXfDTkGSd0QevKWZvEsEisJ7fR1jd6s2o2Xafz ofuXIBttfQQ7RI91Xg7Jk4/su1OJ+3hBMSBU0F4FfJA+NW+lz6gQDmhbV8H+9Q== Message-ID: Date: Tue, 3 Feb 2026 23:28:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Register and attach our DSI device at probe To: dri-devel@lists.freedesktop.org, Joseph Guo Cc: Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Simona Vetter , Thomas Zimmermann , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260112234726.226092-1-marek.vasut+renesas@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260112234726.226092-1-marek.vasut+renesas@mailbox.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 8b8c1e99ae5774b79aa X-MBO-RS-META: fkiwtde55yfuoi81otfpjf4mqimdbpc1 On 1/13/26 12:47 AM, Marek Vasut wrote: > In order to avoid any probe ordering issue, the best practice is to move > the secondary MIPI-DSI device registration and attachment to the > MIPI-DSI host at probe time. > > Signed-off-by: Marek Vasut > --- > Note that this is similar to e.g. commit > 6ef7ee48765f ("drm/bridge: sn65dsi83: Register and attach our DSI device at probe") > and pretty much what every other DSI-to-DPI bridge does. > --- > Cc: Andrzej Hajda > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Simona Vetter > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > --- > drivers/gpu/drm/bridge/waveshare-dsi.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c > index 43f4e7412d722..9254446f54958 100644 > --- a/drivers/gpu/drm/bridge/waveshare-dsi.c > +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c > @@ -80,11 +80,6 @@ static int ws_bridge_bridge_attach(struct drm_bridge *bridge, > enum drm_bridge_attach_flags flags) > { > struct ws_bridge *ws = bridge_to_ws_bridge(bridge); > - int ret; > - > - ret = ws_bridge_attach_dsi(ws); > - if (ret) > - return ret; > > return drm_bridge_attach(encoder, ws->next_bridge, > &ws->bridge, flags); > @@ -179,7 +174,7 @@ static int ws_bridge_probe(struct i2c_client *i2c) > ws->bridge.of_node = dev->of_node; > devm_drm_bridge_add(dev, &ws->bridge); > > - return 0; > + return ws_bridge_attach_dsi(ws); > } > > static const struct of_device_id ws_bridge_of_ids[] = { Is there anything that should be done with this patch ?