From: Miaoqian Lin <linmq006@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: Fix NULL vs IS_ERR checking for module_get_next_page
Date: Thu, 10 Nov 2022 12:18:50 +0800 [thread overview]
Message-ID: <ffda7120-c2aa-d093-a2a5-f5d169c7651e@gmail.com> (raw)
In-Reply-To: <Y2x5a1YVbvmqrK9O@bombadil.infradead.org>
Hi,
On 2022/11/10 12:09, Luis Chamberlain wrote:
> On Thu, Nov 10, 2022 at 06:58:34AM +0400, Miaoqian Lin wrote:
>> The module_get_next_page() function return error pointers on error
>> instead of NULL.
>> Use IS_ERR() to check the return value to fix this.
>>
>> Fixes: b1ae6dc41eaa ("module: add in-kernel support for decompressing")
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>> ---
> Thanks queued up. How did you find out? Just code inspection? I see
> chances are low of this triggering, but just curious how you found it.
I found this by static analysis, specifically, I obtained functions that return error pointers and
inspected whether their callers followed the correct specification.
> Luis
next prev parent reply other threads:[~2022-11-10 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 2:58 Miaoqian Lin
2022-11-10 4:09 ` Luis Chamberlain
2022-11-10 4:18 ` Miaoqian Lin [this message]
2022-11-10 6:05 ` Luis Chamberlain
2022-11-10 6:26 ` Miaoqian Lin
2022-11-10 18:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffda7120-c2aa-d093-a2a5-f5d169c7651e@gmail.com \
--to=linmq006@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®