From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886B1C2D0EC for ; Tue, 7 Apr 2020 19:05:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EE4C20748 for ; Tue, 7 Apr 2020 19:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbgDGTFy (ORCPT ); Tue, 7 Apr 2020 15:05:54 -0400 Received: from smtprelay0106.hostedemail.com ([216.40.44.106]:38812 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726736AbgDGTFy (ORCPT ); Tue, 7 Apr 2020 15:05:54 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id DA3271802CCA2; Tue, 7 Apr 2020 19:05:52 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pipe70_33360acc5b61e X-Filterd-Recvd-Size: 1868 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Tue, 7 Apr 2020 19:05:51 +0000 (UTC) Message-ID: Subject: Re: [PATCH] checkpatch: Fix a typo in the regex for $allocFunctions From: Joe Perches To: Christophe JAILLET , apw@canonical.com, Andrew Morton Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Tue, 07 Apr 2020 12:03:52 -0700 In-Reply-To: <20200407190029.892-1-christophe.jaillet@wanadoo.fr> References: <20200407190029.892-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-04-07 at 21:00 +0200, Christophe JAILLET wrote: > Here, we look for function such as 'netdev_alloc_skb_ip_align', so a '_' > is missing in the regex. > > To make sure: > grep -r --include=*.c skbip_a * | wc ==> 0 results > grep -r --include=*.c skb_ip_a * | wc ==> 112 results Acked-by: Joe Perches > Signed-off-by: Christophe JAILLET > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 529c892722b9..c392ab8ea12e 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -479,7 +479,7 @@ our $allocFunctions = qr{(?x: > (?:kv|k|v)[czm]alloc(?:_node|_array)? | > kstrdup(?:_const)? | > kmemdup(?:_nul)?) | > - (?:\w+)?alloc_skb(?:ip_align)? | > + (?:\w+)?alloc_skb(?:_ip_align)? | > # dev_alloc_skb/netdev_alloc_skb, et al > dma_alloc_coherent > )};