From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout05.his.huawei.com (canpmsgout05.his.huawei.com [113.46.200.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3B731F9B7 for ; Mon, 23 Mar 2026 08:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.220 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774253693; cv=none; b=lAvzkvs6I5vpbtrray2AW6A5ekHgvj5+UoWwjBPQTUHJi6fT4xtX6nHW7lDFEpVhXjMOfLn88wNIkpZJLffnp9Gc5bjqugaOqFxgSspPwfOzx92xyyy2yJiULYoJAr5Wq53wTK2YFuwC27eDCzBa4Cxxcl/MnmE1Fnoub0I3su8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774253693; c=relaxed/simple; bh=OX9i9657rqh0tMrL7J6q02tl7GA5MFfns58QZtChDIU=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=CXAPABg/FcU+e8gYBOJJC5ZOV2+hATeHylbbjInL6DLSciPdgSNVuCTK9JzHEReti/YIKJi41t8VX8qnDEBUwUgcjLEySjJ+xUdcuPsE2iXHaBpOhLKjQMgBsYIT4JKkyqd92VYjz1T3GK/ny9x8lRABoOBc+Q9rLH6/WaHpolY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=QEGT5bco; arc=none smtp.client-ip=113.46.200.220 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="QEGT5bco" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ZmKRW33GAr37NOT5Cd5Kl7lHXle81ghhytPRhfwjjwE=; b=QEGT5bcoqa5rXdO8WxtS241ofoVPPeTAo6keItAA1I5lpVeasst1k+bhvHzDH0jRCt/3hYBBt o8uyuhzCC9qssZ0EVvkyat3zo5koo6D29rKBWvjwVoKjiOKejKtlX1Qz6xP/pGaY5Tp7BDMKe+I iQMufv7yu8izNRsKLbMJX08= Received: from mail.maildlp.com (unknown [172.19.163.104]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4ffQmn0Qkrz12LDT; Mon, 23 Mar 2026 16:09:13 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 92215404AD; Mon, 23 Mar 2026 16:14:41 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 23 Mar 2026 16:14:40 +0800 Subject: Re: [PATCH] ACPI: APEI: ghes: mark ghes_in_nmi_spool_from_list maybe unused To: Breno Leitao , Rui Qi CC: , , , , , , , , , , , , , , , References: <20260316082842.84356-1-qirui.001@bytedance.com> <6ccfd504-adfd-473b-9317-0fc536acc939@bytedance.com> From: Hanjun Guo Message-ID: Date: Mon, 23 Mar 2026 16:14:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To dggpemf500002.china.huawei.com (7.185.36.57) On 2026/3/17 17:39, Breno Leitao wrote: > On Tue, Mar 17, 2026 at 11:55:52AM +0800, Rui Qi wrote: >> On 3/16/26 5:03 PM, Breno Leitao wrote: >> >> If there is consensus that we should address this via conditional >> compilation instead, I can follow up >> with another patch that wraps these helpers in something like #if >> IS_ENABLED(CONFIG_ACPI_APEI_SEA) || >> IS_ENABLED(CONFIG_HAVE_ACPI_APEI_NMI). > > This approach would be worse, I would say. Your current approach seems > cleaner, IMO. Looks reasonable to me as well. Thanks Hanjun