From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C40419315 for ; Tue, 21 Jul 2026 06:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616528; cv=none; b=pL/hW12JwqYiiXpmznQtS1uRcs/0svHGHb8zSfmDPO6+uVsfyW7fZrTk4yMhPd/x+CM7xOyhH2UkH81L6r3OfvPoF4iBwh5L8+PPZ4TiEoEbhht+RMS6LYrSygrU0A0r/36Jd0x9nVV6j8naXRZRtAH80MWJpS/Qtp0egnYZ8xU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616528; c=relaxed/simple; bh=z+bkjq8XsnBjqfaHbLzS3rge7dPv6GGX6S9Z7FP/uck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FIZwacAD65MXvi6vLPB+JV/kUJ9Z45+mtT3MjWjXTxVwvtClrrsIjOydBOPRpL/K1F4pbkZjExsdtqYSuulK+/f+CWlCbIJhpxoGRUm2odtUEnfP6Tlxu0RwFp8tRddFE/dH5Dd+p0AW9a8n5p1GUd4JWpawKUKjha6NB1PWHQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WPZO01kW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LrJb3ylC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WPZO01kW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LrJb3ylC" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L6J1HI045338 for ; Tue, 21 Jul 2026 06:48:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BdMp5QIbHvBUMT7DRnUAlf+M7XjnZBgSQoeTMzQIRys=; b=WPZO01kW8hcpWvqy POAKaAD38+WQT6dYcD63KRfdRZlurtb2lGiKxgrmAEhDyd4TqiRuy0AwSYYJ3hfl sYCyj0ug7oMoyjYzip142j61MJzZLd2hmyk6J/WaTRx0VTwGeEmzFFMLopS3EC39 numGkTcs1BZTx2VGi8zONM7VLjL+ixtfhaxQN6uKz4gYZUlTjUX6k4+9D8ls1Z4d ury0w8orS4ZO+IivmwfiDTBLaQ9TrdpJWhmONWlZ1JMCrkkiSX/wiQOkDT3pqJqK wMwCUoYfg2CpAGFeMK9jxB+On58b3XWcafip+ADZDLXJHL/qgvO6Or2f5rE0WwBm 88WbLA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhqv5tse3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 06:48:45 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc8bde6318so196543795ad.3 for ; Mon, 20 Jul 2026 23:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784616525; x=1785221325; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BdMp5QIbHvBUMT7DRnUAlf+M7XjnZBgSQoeTMzQIRys=; b=LrJb3ylCooaXmv/mhWVnY/hKa+bCx5uiX0AW3+0FUiMBJX6rHZi7tgRk8pBw3Q2jQN 7Ps441SLwTCcDtwWTjG9v3lSrFaEmPTohB2PjfMChHjoG4Br+5RBBbFlj15Wws4d0y2M zweS1i/xPEoOcyGXT0C7AxBhzOoWQvKqFd0MLTn9aUkgFgV+L3ZecGOlAS+DQVyt/dWo 2LEsNYoNhEgaf0B7jCtHEE5TKDzhkLrRXCPmt+r4PeBp1dAWYGOxk+d7VBN/GaFGmSjd enAMA+PE3Xktj1dfdYWgf/9qOL/DNzF/JY9U5GUPgZXM7k8sWN3g0wLq1HGziJhzbVA3 YG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784616525; x=1785221325; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BdMp5QIbHvBUMT7DRnUAlf+M7XjnZBgSQoeTMzQIRys=; b=g1aEvGsFmjyfMN2Tan4/CZZzv6xtwTy1u/wC8JEPQwwo1hgNsbAtUss+RECEMQBSM9 y12qti1NBULehR2YXyeeRIqYXj0qYoIFJ0SFkz6W3SBBIcXnbVc8G8Lc7NhO9BgNVNx0 m7CS8A85EtPfeSxwIvxhz1c2uOMTh2nCx9weTrXxxOO8+7DEVgypgfQ2q4KxAXW3FbjN SzEIWuwWknCn5Nt5lH3Xg9U4qAuYFp7Ww/COzKOymWSUBpOuV51iFkYVcT4Bb4F4QRI2 XeMY4BjmlMArBKoLD5zxKtevWsLH1SRrPWWftUfQuP0PmixTseY/35vd/+T1GdlBdwSo TLZA== X-Forwarded-Encrypted: i=1; AHgh+RqfLSGhr+mESdeS9PLm0rN7BQJmRiv3/Nyc6MjGunVsqriW9UtRb3dsm37VrExj85gIEQpqXuDFyVOmvg0=@vger.kernel.org X-Gm-Message-State: AOJu0YxYAV83JNz59op2q2JdEun9vq/o3g5zhDyZu95lZNC5421TLHxD AS23qYG7hrzK2D7iP2XDYgONNCaJ7pHGc8qZ3zCBzcLWf0le6vrxRPUb0zkBml46kqm+vEBvUII y9Qvf8lVUnrznoRQsfoDdTLRLpZoQn9MMPSIIFGA+NvpPPFoC/gwSsK897oAd0/ebT6I= X-Gm-Gg: AR+sD135M4n2YQcYSfZDo4eEjMzpJIKlHszzVKpMNNVbZC0eVK1ackD1jEhuGVFal4y 8lZYxgKHgrgNtW3rTxYBX/GiXW1VRivCCjS6YL3MnnJTArV0dPNQy6c9lDFmDf1Mb2fwO6sNCHL E825REqiLzGXOmTGrp+NxruX/oegWGVwcHL7V1XAvt9cM1G6sSaNCXxv3bVS9/R/VO7QPbvOyRt zVuqM7s9sjF4RfciJ30Wv4NLtSek4Z9Fut8bRd+uFOrG77vx01Z+jh3ckgpluMmHfKXvdjegZVs eG1hWN0V33xBNR1E8VonmOQvaTvS9zvG/hwvMwts1BMRRgB1oQ1mYvSi359u7F3tJiE6ahohhLQ woN23wz4JNGXwre/BKUyUhlFgfH1EunY= X-Received: by 2002:a17:903:166e:b0:2ca:ea56:7a58 with SMTP id d9443c01a7336-2cf34a49553mr189544485ad.37.1784616524753; Mon, 20 Jul 2026 23:48:44 -0700 (PDT) X-Received: by 2002:a17:903:166e:b0:2ca:ea56:7a58 with SMTP id d9443c01a7336-2cf34a49553mr189544055ad.37.1784616524256; Mon, 20 Jul 2026 23:48:44 -0700 (PDT) Received: from [10.217.199.117] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf34769bd6sm69948485ad.74.2026.07.20.23.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 23:48:42 -0700 (PDT) Message-ID: Date: Tue, 21 Jul 2026 12:18:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants To: Daniel Lezcano , Dmitry Baryshkov Cc: Konrad Dybcio , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <10a346d8-fbb1-4142-a650-507c3917b8f6@oss.qualcomm.com> <1aca8d60-8e39-4532-9095-a5260bba76ac@oss.qualcomm.com> <9dc4b29e-e9fb-421a-b789-eb16a68ff915@oss.qualcomm.com> <2tu35aavp7sc2npni33ky5bve57idzy3bzp2pk7eh5lryq3r4v@gmm3dhayu4cf> <6f179f96-fdd1-4fa9-b26c-df7372eb6d20@oss.qualcomm.com> <54250163-678f-41e7-97d0-6596123367f1@oss.qualcomm.com> <3b9f1b3d-4c06-4006-82d5-d59ce2101070@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <3b9f1b3d-4c06-4006-82d5-d59ce2101070@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA2OSBTYWx0ZWRfX7+RNEGxWcmjX c3D8HB/U0ADqqKSrq3T0GS5KaDUnNQpbN3eXZf7+/srFjq6d1+4hozSfBF+/HPjRkfjDQ+/kSxo rOYtcC/t2UEJq0Y5RAhxQrz2KUEID9kymWWTqK9QiBQl9ZffGcBFJcGrmi7JBGk2D06Orq1xiLL Rhcing7UCFFdC+4kJ/mLV42eWR/DhbUG3xymhTW0p3UzHrGspc9CZkSTnK/PMa15BGACuWE5Lcc eWdhWOjI5qiVSzT3xm847AXtDNYwtQJGbg7Bv4SYvX8OFhXAPiWyG1GwxWBObK0NEMnuGGobe3r qTf/mQG0jqz/cgGy0WpMRH/cCI+ynGhrHdZmmL8OkQK8HUBdViRzsNexRuhNkOIs963KxLytcE3 i/zCROVHeil4nSnj7j2UfVzmbfsOHmMzvQEGEHY+XWvNYKkvG32LS977GL3qXpHTkul4rohFPKv A7FCGtKJBXav1l4G58g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA2OSBTYWx0ZWRfX4g4rxlV/tmLy ne6cEkUCKad4L/2hk0zDuQB1IH/NXkImk3bimd6Jkzj979ItnM+zvlloBHZwA0x37vzhlHBuvil QFLvSvX4gW8uG3FesnAWsYvPci1ZdKA= X-Authority-Analysis: v=2.4 cv=WNpPmHsR c=1 sm=1 tr=0 ts=6a5f164d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=YHEYuCYylZzveZTXVIMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: pQwnwwqselp85_85UT6MczfiZx7QQpMt X-Proofpoint-ORIG-GUID: pQwnwwqselp85_85UT6MczfiZx7QQpMt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210069 On 7/9/2026 1:53 PM, Daniel Lezcano wrote: > > > Le 09/07/2026 à 09:58, Dmitry Baryshkov a écrit : >> On Thu, Jul 09, 2026 at 09:42:04AM +0200, Daniel Lezcano wrote: >>> >>> >>> Le 09/07/2026 à 09:37, Dmitry Baryshkov a écrit : >>>> On Thu, Jul 09, 2026 at 10:54:26AM +0530, Gaurav Kohli wrote: >>>>> >>>>> >>>>> On 7/8/2026 7:55 PM, Dmitry Baryshkov wrote: >>>>>> On Tue, Jul 07, 2026 at 03:55:13PM +0530, Gaurav Kohli wrote: >>>>>>> >>>>>>> >>>>>>> On 7/7/2026 1:04 AM, Dmitry Baryshkov wrote: >>>>>>>> On Mon, Jul 06, 2026 at 08:11:35PM +0200, Daniel Lezcano wrote: >>>>>>>>> On 7/6/26 19:47, Dmitry Baryshkov wrote: >>>>>>>>>> On Mon, Jul 06, 2026 at 07:03:18PM +0200, Daniel Lezcano wrote: >>>>>>>>>>> On 7/3/26 17:42, Dmitry Baryshkov wrote: >>>>>>>>>>>> On Fri, Jul 03, 2026 at 07:43:39PM +0530, Gaurav Kohli wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 7/3/2026 1:23 PM, Konrad Dybcio wrote: >>>>>>>>>>>>>> On 7/3/26 7:03 AM, Gaurav Kohli wrote: >>>>>>>>>>>>>>> Add Device Tree binding constants for Qualcomm Thermal >>>>>>>>>>>>>>> Mitigation >>>>>>>>>>>>>>> Device (TMD) types used by remoteproc-backed thermal >>>>>>>>>>>>>>> cooling devices. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Qualcomm remote processors expose thermal mitigation >>>>>>>>>>>>>>> endpoints >>>>>>>>>>>>>>> through QMI. These endpoints can be registered with the >>>>>>>>>>>>>>> thermal >>>>>>>>>>>>>>> framework via the `#cooling-cells` property on the >>>>>>>>>>>>>>> remoteproc node. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> The QMI TMD protocol identifies devices using string >>>>>>>>>>>>>>> names (for example, >>>>>>>>>>>>>>> "pa", "modem", and "cdsp_sw"), while the DT cooling- >>>>>>>>>>>>>>> device binding with >>>>>>>>>>>>>>> `#cooling-cells = <3>` requires numeric device id in the >>>>>>>>>>>>>>> form: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>          <&phandle device_id min_state max_state> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Define common TMD device index constants shared across >>>>>>>>>>>>>>> currently >>>>>>>>>>>>>>> supported platforms. If a future target requires a >>>>>>>>>>>>>>> different mapping, >>>>>>>>>>>>>>> additional target-specific constants can be introduced >>>>>>>>>>>>>>> while preserving >>>>>>>>>>>>>>> existing DT ABI. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Signed-off-by: Gaurav Kohli >>>>>>>>> >>>>>>>>> [ ... ] >>>>>>>>> >>>>>>>>>>>> Why are you using only those TMD devices? >>>>>>>>>>>> >>>>>>>>>>>>> More constants can be added as needed. >>>>>>>>>>>> >>>>>>>>>>>> Kodiak is one of the supported platforms. >>>>>>>>>>> >>>>>>>>>>> What would be the benefit of having more than thirteen >>>>>>>>>>> cooling devices >>>>>>>>>>> declared in the thermal framework and having only a couple of >>>>>>>>>>> them mapped in >>>>>>>>>>> a thermal zone ? >>>>>>>>>>> >>>>>>>>>>> I agree there are more TMDs but if they are unused for the >>>>>>>>>>> moment, why do we >>>>>>>>>>> need to add them ? Can we do that incrementally ? >>>>>>>>>> >>>>>>>>>> That's what I am trying to understand: why the implementation >>>>>>>>>> uses only >>>>>>>>>> the selected two devices, if the modem on Kodiak supports >>>>>>>>>> others. How >>>>>>>>>> can we find out, which TMDs to use on other devices. >>>>>>>>> >>>>>>>>> My understanding is that is an initial thermal setup. Gaurav >>>>>>>>> will add them >>>>>>>>> step by step while setting up all the thermal zones instead of >>>>>>>>> sending a big >>>>>>>>> patchset. And TBH, that will be much easier to review. >>>>>>>> >>>>>>>> In such a case it should be noted in the commit message and/or >>>>>>>> cover >>>>>>>> letter. >>>>>>> >>>>>>> Thanks for the review/guidance. Not all TMD endpoints are >>>>>>> relevant for >>>>>>> kernel thermal zone binding — some like BCL and cold temperature >>>>>>> are handled >>>>>>> from userspace when needed. The constants here cover only >>>>>> >>>>>> What if there is no userspace? Or the userspace is different from >>>>>> what >>>>>> you expect? I doubt we have TMD-speaking userspace yet. >>>>> >>>>> Thanks for mail, The TMD userspace implementation is available >>>>> upstream at >>>>> https://github.com/qualcomm/qmi-framework. >>>> >>>> Is it? >>>> >>>> lumag@rohan:/tmp/qmi-framework$ git grep -i tmd >>>> lumag@rohan:/tmp/qmi-framework$ >>>> >>>> I found no traces of TMD there. Moreover, I don't see why QMI framework >>>> implementation would react to thermal events. >>>> >>>>>>> what is needed for modem and CDSP thermal zones on the currently >>>>>>> posted >>>>>>> targets. >>>>>> >>>>>> Again, SLPI, ADSP? >>>>> >>>>> Sorry, I should have said "generic subsystems" rather than listing >>>>> specific >>>>> ones. SLPI and ADSP do not require active thermal mitigation on these >>>>> platforms. >>>> >>>> Could you please provide details, then. What is cpuv_restriction_cold >>>> TMD? >>> >>> It warms up the zone when the temperature is too cold >> >> So, if we ever get back to supporting warming up, these TMDs would >> become relevant. Am I right? > Probably > > Can we do some progress with these TMDs definition ? > > Spending 95% of the effort to discuss 1% of the proposed changes, which > is always DT discussion, is quite frustrating :/ > > You want to add all defines for existing TMDs for all platforms ? > > We are talking about numerical values right ? Why is it a problem to add > their define later ? Sent a new version. Added a note in the cover letter clarifying that only kernel-managed TMDs are included in the DT binding. Please review. >