From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbdKHN1r (ORCPT ); Wed, 8 Nov 2017 08:27:47 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48452 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751674AbdKHN1p (ORCPT ); Wed, 8 Nov 2017 08:27:45 -0500 Subject: Re: [PATCH] s390/dasd: avoid calling do_gettimeofday() To: Arnd Bergmann , Jan Hoeppner , Martin Schwidefsky , Heiko Carstens Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171106140328.1498644-1-arnd@arndb.de> From: Stefan Haberland Date: Wed, 8 Nov 2017 14:27:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106140328.1498644-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-TM-AS-GCONF: 00 x-cbid: 17110813-0016-0000-0000-000004FEF173 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110813-0017-0000-0000-0000283A956D Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-08_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711080186 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.11.2017 15:02, Arnd Bergmann wrote: > do_gettimeofday() is deprecated because it's not y2038-safe on > 32-bit architectures. Since it is basically a wrapper around > ktime_get_real_ts64(), we can just call that function directly > instead. > > Signed-off-by: Arnd Bergmann > --- > drivers/s390/block/dasd_eer.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/s390/block/dasd_eer.c b/drivers/s390/block/dasd_eer.c > index 4630782b5456..5169c717c9d6 100644 > --- a/drivers/s390/block/dasd_eer.c > +++ b/drivers/s390/block/dasd_eer.c > @@ -296,7 +296,7 @@ static void dasd_eer_write_standard_trigger(struct dasd_device *device, > { > struct dasd_ccw_req *temp_cqr; > int data_size; > - struct timeval tv; > + struct timespec64 ts64; ... > + ktime_get_real_ts64(&ts); > + header.tv_sec = ts.tv_sec; > + header.tv_usec = ts.tv_nsec / NSEC_PER_USEC; > I renamed ts64 to ts to match the usage below and fix the compile error. Beside of this, applied. Thanks for the patch.