From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A4D1FBC8E for ; Thu, 21 May 2026 04:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779337721; cv=none; b=mCuyBsfOXlvQsFe/+R025ZW6C2uCBlctT1oxpZVidx2x2eFv2JlflKoFoILR5tGpXG0touZlygEfDWYMREHRJ4jdctDv608JZXWlIF73d75G1KXhIqZBVqIlBYd1c141QCn/xBeIuAuc7Xah8GxM4MTkJrXHqSx5RZVA4yyaLbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779337721; c=relaxed/simple; bh=1fn8nNIfAciVYywUEDqcLHwnewpkWRfNE2Jm7RnUmr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oC88lVIE5d1eXNq4FDykugMIkZGo2Hyk3S8wAHmARy1Dtr23fDBw/NPq6xJGUZuqnVCBWItuq9cZdIC5HExa6YV1CSrbM74GAQBj3QWoSl2A9YZEb/nIm2y8xIG+/N8QCHLRN1wtqfhrxgiYHHC92nzGH3dmkS8ggi0AJdKYikk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=j+5JhcKT; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="j+5JhcKT" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1779337707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0Mbqj52klJDaYVrqr1HbvDq6wUyKpixCsk5uYYS4F8=; b=j+5JhcKTMjPxoUC95Kz4ElJaqjQUSuzJHi6aj64lHfnS50ZbSIYktmGl372tbEL79RTofN Nh1suA+1ruN6eq8riu6dLM6xdrX04zvx5nNkrTDg1UYWIFfDfDOFfifwWh+f+IWysIzoxT LU/a/OHrOl5+mbuk/yHlVBvvIq0qQB5/0+Wh48+4E3pDjVUQCx7bvx+4mmF5MMFekqlhYX NNFKcFeDjfskZTBH69uO1aG/mzybsdAsxks4vUObfgcU3MjNA0aH73HePwBUm7KaHGR1MK itCFy+IG+gUZYDlj/AP0mj5tqj4nIsOIIk7crQ3O3ZzaCU3IX3V+h2x5Wc4iMA== Date: Thu, 21 May 2026 01:28:16 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: x1-dell-thena: mark l12b and l15b always-on To: Michael Scott , linux-arm-msm@vger.kernel.org Cc: vkoul@kernel.org, neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com, wesley.cheng@oss.qualcomm.com, abelvesa@kernel.org, faisal.hassan@oss.qualcomm.com, linux-phy@lists.infradead.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, bryan.odonoghue@linaro.org, laurentiu.tudor1@dell.com, alex.vinarskis@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260521010935.1333494-1-mike.scott@oss.qualcomm.com> <20260521010935.1333494-4-mike.scott@oss.qualcomm.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Val Packett In-Reply-To: <20260521010935.1333494-4-mike.scott@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/20/26 10:09 PM, Michael Scott wrote: > The l12b and l15b supplies are used by components that are not (fully) > described (and some never will be) and must never be disabled. > > Mark the regulators as always-on to prevent them from being disabled, > for example, when consumers probe defer or suspend. > > Note that these supplies currently have no consumers described in > mainline for dell-thena beyond the audio codec (vdd-buck/vdd-rxtx/ > vdd-io on wcd938x), which can release them when the codec goes idle. > The board-level gpio-fixed regulators that feed the Type-C retimer's > VDDIO and other rails are not described with a vin-supply link, so > the kernel cannot keep their parent LDOs alive on its own. > > This mirrors the same change Johan Hovold applied to every other > X1E80100 board in a March 2025 series; commit 63169c07d740 > ("arm64: dts: qcom: x1e80100-dell-xps13-9345: mark l12b and l15b always-on") > is representative. The dell-thena board file was introduced four months > later and did not inherit that change; this patch closes the gap. Acked-by: Val Packett Asked a friend who has totally legitimate access to the XPS schematics about what those components are: L12B: IO_1P2/275mA - MOSFETs and pullups on a bunch of I2C, PCIe CLKREQ/WAKE, etc. - VDDIO for WSA speakers - NVME_PLN_N_1P2 (Power Loss Notification?) - bunch of VDD_PX pins on the SoC L15B: IO_1P8/1.09A - MOSFETs and pullups on eDP HPD, bunch of I2C, PCIe CLKREQ/WAKE, some INTR#/RESET#, SSD Load Switch, etc. - VIN for Load Switch outputting retimer's VDDIO - VDD_1P8 for WSA speakers - VDDIO for power monitor ICs on IR_I2C Yeahhh.. I think the load switches could potentially be modeled but the huge bunch of random pullups not so much. I wonder how Windows handles this. Maybe it could be in low-power mode when speakers are idle? ~val