From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A1051FCF6D for ; Wed, 8 Jan 2025 14:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736348137; cv=none; b=tt8W5+4OguyW/pT2JIakSKpq+B+pautaMB5FVRksQ5Hcry+ZXCq1iJTgp9wSLJyuwSPOa56hFPrK5LQUB89xQDr/hLd23nvDwtY//nLevUQs1pDe8vq0IcnVUnSiHfD5BXqsx4h8yyyMFLvFhl4pfkPKZeRD2RNUKC2WB4WlIEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736348137; c=relaxed/simple; bh=67JK1rlmJtGcesXL4SPQSN/FDXqiuAIio1r2G9KnuLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uy9XXaqF2KV3eQh6g6Z5h5lBRipPNDuKusUnbQ30X1NGLqcr/+cyn3WFx8QAfbPn2xRf4u29iawwyihNCc2Ld6/b7Fn4P/XLV4jlc3v/GxVpPwjC4tdX681wGsD+I0GlTk19AGiNdWjrwkm097PGxHXc8Tgz6xp52nyRWL78lTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gTQ9OZV5; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gTQ9OZV5" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aaec61d0f65so280989666b.1 for ; Wed, 08 Jan 2025 06:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736348134; x=1736952934; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x+O0NMpY6QzRmleywGIkKRE2USypKZLsxBppr3RZn6U=; b=gTQ9OZV5Glt4NgQCChHsIO7gTRCxfCNANjgUeGdow3pdDXjJlUQZQBvV2GMGuoKe2t 30Q6zBXDekFd8Z1h6nI+uFXANA+Zzi/GIfciF7uBIyEbRaRlcH63KbR689EvLKqcp6uw BJvCzjcPEfDXPz3JGS2qflBzoNOKc4CkOCfGJPeMJZs8jhNwAhr1Xzm04PEozucDQTCL F3xRm6gzgIguPb1W2CASAOe7WNeiwqVwr9aSNQNSX9jCgYNd74b5xV5424lGqu7DzGg0 BAPqOwsCKGq/O2+3PUO9Gbw/jGolEvG5LUO1I7Zxg7KnWRHT1GtvLlCJHU1Z60T5VqfX +mug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736348134; x=1736952934; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x+O0NMpY6QzRmleywGIkKRE2USypKZLsxBppr3RZn6U=; b=AKtVE3Utc4asn8cqOeVKfNx/qFjuA2UfF+/WAoP/KBF+px8b5ngOKchfhnQzGVPJQL rKLIVWfahMohOF+MIIWBAmTI5YhOjWNJc7ZlyLmyANzdLI4w0yMEeFzyYasgm3QQm7Cv IOyvgrQoj/l5ZGfEn4a2D16O2mOjqPgRmIvmH1/qtJQlAVh8ryEbDSiKQTXExFbEspCg bRr5w/TprQPPsM2qOj4PPNULtoZPZXYcSnOTEVs5zt3guuY4M7lx6F2FVnwGa47x8kjz +8RUSYwcEqnG9STOwd3B6Lm3mEfZ18APAcNuUDJHRIb0JESgodYgG8F0Wn7nkK/05Tbw aD1g== X-Forwarded-Encrypted: i=1; AJvYcCUh0+rTvNbT6c5V/gXhtKGL+hYTULCdWMpjSO9uJUbrjZZHlzecbZ/117LMMPzCy5C0W/fJBgRcC7tl+94=@vger.kernel.org X-Gm-Message-State: AOJu0YyUMm/SAPLFLD4I/R8+pjS/zJ6yAC/rRj6OrdYAN13glgOWiHjf HRxkZfAuxjuv3Ebkth6Vs9vhC9a5JRjKPebvhQ5XCWX7oFDOV9L/qtGcfUuNT1Q= X-Gm-Gg: ASbGncsM3YS7/Z98icnQgyBe0lurSn5hw7DG/ZPtiiNTJ9vEdJ9zpm+45uOzm7cbzcE iAiJlvhy0QGEtAjRrHg6gasvRazMkMrm4VzVlPfB0U1klfaVdWGZ5su7MXN98pbyamlp0nZVCm7 ucvF/yWr1A7aJnD2198X2dwZA6dUjh6e/GwFCdv0PgjLPTseP9mop90PRfF41Dg17CBawW6IPHg gI8uq5fqvy3v+lFk5CN7qzGF5qaa2hPGs5EmbefWdl7ZhPFQSphBsVIGT7TsAAc24tL5UgmCSHK cf7nuqI0WB6nNtJMOqsW54L9raY1OG6Rz2glQTs= X-Google-Smtp-Source: AGHT+IFnWVoDQuHcKTyFxi4kBSfHYu1d60lV+zwr2XqYC5cBIMfaq1XRcTiYwNflIFjII+AZubU8Uw== X-Received: by 2002:a17:907:7e91:b0:aa6:4a5b:b729 with SMTP id a640c23a62f3a-ab2ab6f3447mr256057366b.33.1736348133620; Wed, 08 Jan 2025 06:55:33 -0800 (PST) Received: from ?IPV6:2a02:8109:888d:ff00:ca7f:54ff:fe52:4519? ([2a02:8109:888d:ff00:ca7f:54ff:fe52:4519]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d983a172d9sm73309a12.57.2025.01.08.06.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 06:55:31 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 15:55:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: qcs9100: Add support for the QCS9100 Ride and Ride Rev3 boards Content-Language: en-US To: Konrad Dybcio , Tengfei Fan , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: kernel@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240911-add_qcs9100_support-v2-0-e43a71ceb017@quicinc.com> <20240911-add_qcs9100_support-v2-4-e43a71ceb017@quicinc.com> From: Caleb Connolly In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/09/2024 01:32, Konrad Dybcio wrote: > On 11.09.2024 1:10 PM, Tengfei Fan wrote: >> Add device tree support for the QCS9100 Ride and Ride Rev3 boards. The >> QCS9100 is a variant of the SA8775p, and they are fully compatible with >> each other. The QCS9100 Ride/Ride Rev3 board is essentially the same as >> the SA8775p Ride/Ride Rev3 board, with the QCS9100 SoC mounted instead >> of the SA8775p. >> >> Signed-off-by: Tengfei Fan >> --- > > Reviewed-by: Konrad Dybcio I don't understand this, if both boards are identical except for the name of the SoC then why do we have two devicetree files? You can surely detect which SoC is in use at runtime if necessary, and maybe pick a name which doesn't have the SoC in it if you really want to avoid confusion. If there are differentiating features which will be added later, then I think this at least deserves a comment stating as such. Additionally, the files should be shuffled around to better represent that there's two very similar boards with just some minor differences, this is a common case already and there is a standard way to handle it (see e.g. sdm845-oneplus-common.dtsi and sdm845-oneplus-enchilada/fajita.dts) #include'ing a .dts file just seems like a mess here. Kind regards, > > Konrad -- // Caleb (they/them)