From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f225.google.com (mail-qt1-f225.google.com [209.85.160.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6943E347533 for ; Wed, 27 May 2026 23:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779925317; cv=none; b=HfT2ALXk6xYq0m4aD4L6G+Utb/YcbwOakqVSkv3CdDMujbl3wZS6wxJmejTMEBNMq1T6Tvi08XXyQA2s4RYBKccgGZYIra4mGe0MXE5d+ZFfKlHKnCTvzy7zi/IBj8vWhAmyomHmrPnCqNa6hT5dMUb5cmomiY88Ysj0vT4UgfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779925317; c=relaxed/simple; bh=jS/81g50QX1pwl3mCuVBsyIxC6RqiiAm1chmDMbCihQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=YMVPcSlvKNEPt3lUx/3yLchuj0+1raGopEso6suQiw3ijvHquLmGynZrSzwUKEeF2SqcR9DnOOF76kAutAyQ0iWLKxXIg2AUesut+qt+sAW1LreXqr3Xzd/ntNZ1GMOmiJ1a7TJB+Jnzm+jOYNjJiMLCu161tIgHmHmz7zAAYz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=R66gT299; arc=none smtp.client-ip=209.85.160.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="R66gT299" Received: by mail-qt1-f225.google.com with SMTP id d75a77b69052e-516cc597842so34609971cf.0 for ; Wed, 27 May 2026 16:41:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779925315; x=1780530115; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Mv6i6uMQFt+ebplIQhhXFo6hUBIl29bTG6d6cReoRs=; b=Gj15CnaW74aTyWBrL7GQa0195jVdft4SGVJb6s9CzZzafg2+e60gx8ijkkv63qglzx IYBwcHX9uT7DxyZ+kriW+LpYlZ26H2wJtqu1ks+SESdnSth9ziUh2tOO0GGE8Cat2ufx 2DkrPPTVyiMh73ugcRv2BX5islYhjJoSJlX4VfJtf6UNfDIQE//R7Lpx4M2eizYRMLFW G9MEXfvvurGAmQrKT81ryr27r1Z+rLxj6acPxXNLyevOWzgaUqVfmdCHlTeC7Dras+eH crXY88Nk7klkGF7meqpYnX/Qys9ruBWkIam9aCOTSnYsJkfM6OZ+FLi+lsNqoNLRk83q /IdA== X-Gm-Message-State: AOJu0Yxt5L1lC5jjsJ9IJC+8ncR9QtV10g2DN6pemRvSLV3RWNP7JqdM dbnXPmkAsIQ1mRJhmbhn3YopM4WBBnwwIxj4iUV/KCkmU8rDnDbGpR76TzsmGzYNFalWuj/OBxK Z4HcTqfxY7ALK9yjBDoRUUN81TFJv7mQTFB2++nbzBehvt/g4c3rlVLliqxhPDXCnRZ5Z3/qHqN REbgVEmeVA62Y3GcIwrbSJtGX5R/xye6+oBbE//bunfjMk4QBbcLdGO3veHQiZChYC1exSgHWka 3pgePplJZd42ZM2tsp5xkGd X-Gm-Gg: Acq92OGBGBMg2tIL6DwlP7VNSizZ5/nmwYcAZj2Jm70nCdW/PUsuet/beLRmucD/RYe 4AqNHKo3vE9AowcOvMqKLoI5FZ52y8qS5ALdYadXP/8ZZuqiq7Wbdqr9/HXZht7RBAZB9NhH673 Z0vbotCI6WBNmPeQOUDHdawuB2H3433u39nC7XDV7C77pSUstQowRDXSiCa05sPvZIDju04jfot XaKa6oZIcaKJ3DqaYwrNBccdcjqUKMaOF3kk0a7oN/63qvDmdAwaJ7FEUTYbVw2so64uYU+3Baq 087a1JOpYtps5MAh/sT/fmBddFeCYgIy2lPACPphe6aYlRTXXwewIXk/Q2Oz1WuPUQQVDP7408p 8/oyW/IQR3uwSBskhAXAPjJL528iZ5shqUT/yvfYQj8+SrQy1SllQY4cIkiFmz4qKeizHkW3KGn yV/JjAFhBAQxKNOE13YKfC+Hjw6dQTbNsHRYYELNZx35TkzHvyD0G9wR9vygEu/RUFMMtg8ccMK kU= X-Received: by 2002:a05:622a:1e90:b0:516:da42:43df with SMTP id d75a77b69052e-516da424757mr291633701cf.30.1779925315194; Wed, 27 May 2026 16:41:55 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-51706a3d82asm3663531cf.17.2026.05.27.16.41.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 May 2026 16:41:55 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-90ccab62c33so1311383285a.0 for ; Wed, 27 May 2026 16:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1779925313; x=1780530113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8Mv6i6uMQFt+ebplIQhhXFo6hUBIl29bTG6d6cReoRs=; b=R66gT2997mlNKSoJxHE/OidQKbR2Qom1PC3JS5EP/BvSZ8IzegOKYIpvvNcgG96Uzz bXZUus/4GWmQyIXVjQj9xvB43v/iT5JjsoRCA+hpriN1cniIkWi9vJdzQJSngHfwADJ2 cDSoCxnzCKFVkh/WkVJuU/HZLF4uBqTUQhTHA= X-Received: by 2002:a05:620a:2955:b0:914:c01e:6f82 with SMTP id af79cd13be357-914c01e7f27mr3159228185a.21.1779925313592; Wed, 27 May 2026 16:41:53 -0700 (PDT) X-Received: by 2002:a05:620a:2955:b0:914:c01e:6f82 with SMTP id af79cd13be357-914c01e7f27mr3159223985a.21.1779925313082; Wed, 27 May 2026 16:41:53 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f86e8e1esm627408285a.7.2026.05.27.16.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 16:41:52 -0700 (PDT) Message-ID: Date: Wed, 27 May 2026 16:41:49 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mmc: core: Kioxia 016G01 does not enter boot mode after SLEEP From: Florian Fainelli To: Ulf Hansson Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Oleksij Rempel , Avri Altman , Pedro Demarchi Gomes , Erick Shepherd , Adrian Hunter , "open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." References: <20260413180551.3683969-1-florian.fainelli@broadcom.com> <1d583be4-b1cd-4226-bdbe-5ebd275de9c2@broadcom.com> <915473f9-64bc-4630-9c82-41fcf4401042@broadcom.com> Content-Language: en-US, fr-FR Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <915473f9-64bc-4630-9c82-41fcf4401042@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/18/26 20:27, Florian Fainelli wrote: > On 5/12/26 06:33, Ulf Hansson wrote: >> On Mon, 11 May 2026 at 18:01, Florian Fainelli >> wrote: >>> >>> On 5/11/26 07:18, Ulf Hansson wrote: >>>> On Mon, 13 Apr 2026 at 20:06, Florian Fainelli >>>> wrote: >>>>> >>>>> The Kioxia 016G01 eMMC device does not exit SLEEP mode when sending >>>>> CMD0 >>>>> which prevents the system from properly resuming from S3 warm boot >>>>> where >>>>> the eMMC is necessary to pull in the boot components. >>>> >>>> Is the bug confirmed by Kioxia? >>> >>> We've been going back and forth with them without much progress as far >>> as a resolution goes. Since there was no progress and I would like to >>> get this included in downstream kernels at some point, this was >>> submitted. >>> >>>> >>>> If not, can you explain a bit more what is actually happening during >>>> system resume? >>> >>> Upon entering Suspend-to-DRAM, the eMMC will be put into sleep mode. >>> When our systems resume, one of our hardware cores driving the eMMC (HIF >>> block) in command mode will send a CMD0 command for the eMMC device to >> >> Is the CMD0 sent solely by HW/FW before the mmc core executes >> _mmc_resume() during system resume? > > That is correct. The sequence basically goes like this: HW sends CMD0, > then FW pulls in boot code, identifies this is a Suspend to DRAM, does > its steps, and eventually Linux resumes and calls _mmc_resume(). > >> >>> exit SLEEP mode. The Kioxia 016G01 device takes 10ms rather than the >>> tSLEEP_EXIT value of 1ms which is advertised and so our HIF block does >> >> Can you please clarify what tSLEEP_EXIT refers to? Are you referring >> to the S_A_TIMEOUT in the EXT_CSD register for the eMMC card? > > Yes, sorry I am referring to S_A_TIMEOUT in the EXT_CSD register. > >> >> Anyway, waking up an eMMC from sleep state in just 1ms sounds a bit >> optimistic to me. > > Fair enough, but AFAIR we wait up to 30ms before declaring a timeout, > every other vendor we have seen exits and acknowledges boot within > 1-10ms at most. Similarly if the device is not in SLEEP, then it > acknowledges boot within 1ms. > >> >>> not see the Boot ACK pattern in time and does not service the read >>> request from the processor that wanted to read from eMMC, we get a reset >>> of the system, rather than continue booting. >>> >>> When SLEEP is not enabled, the eMMC device responds within tSLEEP_EXIT >>> as advertised and we don't have that problem. >> >> Okay, I see. >> >> In this regard, it's important to understand for me how the mmc host >> driver (and the HW/FW) manages VCC and VCCQ when the mmc core calls >> mmc_power_off() from _mmc_suspend()? >> >> Does this turn off any of these regulators or what happens to them >> during system suspend? > > We don't have software controlled regulators for VCC and VCCQ and our > reference boards using that specific eMMC device keep it powered on > through suspend-to-DRAM. This is the very reason why if it stays in > sleep mode, powered on, and then we attempt to boot from eMMC we have > this issue. > >> >>> >>> So I suppose I could reformulate the commit message and give some more >>> details here if you would like? >> >> Yes, but let's discuss a bit more first. Ulf, did you want me to re-submit with that kind of detail added to the commit message? Also since this is a bit specific to our devices, did you need me to scope the fixup to the ARCH_BRCMSTB platforms somehow? Thanks! -- Florian