From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbdK2Sir (ORCPT ); Wed, 29 Nov 2017 13:38:47 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:34588 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752129AbdK2Sin (ORCPT ); Wed, 29 Nov 2017 13:38:43 -0500 Subject: Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup To: Tejun Heo , Jan Kara CC: , , , , References: <20171010155441.753966-1-tj@kernel.org> <20171129165608.GA26740@quack2.suse.cz> <20171129170330.GV983427@devbig577.frc2.facebook.com> <20171129170501.GW983427@devbig577.frc2.facebook.com> From: Chris Mason Message-ID: Date: Wed, 29 Nov 2017 13:38:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171129170501.GW983427@devbig577.frc2.facebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:180::1:9de4] X-ClientProxiedBy: MWHPR11CA0014.namprd11.prod.outlook.com (10.172.48.152) To DM5PR15MB1657.namprd15.prod.outlook.com (10.175.107.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14feb3ce-9e41-49ed-7210-08d537586449 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603274);SRVR:DM5PR15MB1657; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1657;3:+OMXXiqQbqZG7hN0QR3oYqbt8Yg9AL+5X6kDlK+wL5Vi3fT2xAGxNZUvxTzdVm636xUD35IMugaZyqKsXLKY8YzPYEVbkDErsJ2UXMxLYh/SkkLJCq8S3yGM/MaRuNcuNNGnPUA9Ia9HVCIrv769kDvgXfA/VCnO2kM9h2T5m6Wvn5oGqcfxhMd1qs0iGEgPe4E5x3p8K/3P4fnIXKKxpn9Vgxa2VFIrkIv5CBvqJZEjWcKOUdMuO7PdVNA5pJpa;25:kqB96Mac4tZk0vlml3xUPQzXqg2W2MADxHHQDBi0I3z0G+/g34ofbAY5hAUNoFbMjbPUAwJnos/GQ0C3EAOBCxxKCVor8+tOWqOoOZNqRPgiTdpCHSIVd6cWRr2kNf00J7oeWwDZFzSqiiOw0N9SZEzxdUHn5pJrr/pKCc1Y32pKU+6XNAkGdWYYMr/uGoG+CHUUEuEiZBtYfsn5CyFvhuEqxKBSY32AIxTQNdbMX4wbEPIVbpmCvZM9taze3qrz9Z8Dr+YIKHLYrZqaSVr1nQXD2rtrXyfV7jiKi2L9/4i7DvWS/uVY9I+KdDLkUNOJDfrGQZnl4UMwr2+7Tj2/Gg==;31:n+3VOdhigk4lp7i5G3PCeq0+T0dJbAzeGjkXCsgmhtnNxkVhWEpl4FnEJ0OHTwz/2JZJW03JoP7l8I96A30uKnBvfw5+874kG52oe3OAIzt2u83foteM79vtdxWmmwFDKbfPgEG2+3qCM+AYR+hR6bS6jvlF44I/H0JW/JnMGgn+htTsqpHpRJoquPy1keEqUCuc4d8/s7ltOPXAabL9kLozfq4bD3WN+pbKjr482sU= X-MS-TrafficTypeDiagnostic: DM5PR15MB1657: X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1657;20:LsyMCUOJ1eU6CIhlUmuzlI/sUsA9QycrprU5oW2vSjT4YpL+qL7Kwk082gb0DWRWW9wkDLOcBo6eatklfTPKaZUtnRRS7Pn2mqtWXZeWiXSDhtAazD3eYzCPNhs7MCg1o+DzRhiTp02FZFz/ari82P63XnRb7x/XWkpOPEi9PK//rW392TlJ/5LBvkcT0vELTiqJ/OvlLU4wtP9IO+HnclYQIJkNzkLej/pI4l2IFXbUUXh5MGXyh7pJqJriwtmeZj/Stmhq2ett4A7h/BVJcPoWPx6cNNq0RHpt7e4mrF6PXA5b7TmFdcd8l3358wiwqIkqF/iRf1PRSGgjuBEC4HITgta/JWwZB4iLchZfBueGYtjovpkuOOe3j5petSmaNTSnKgsu5AwYkF0SCbdk5NnUsg5DLsj+5KxAPsiXYM49fFRrDvgBIO6K8/WPJ8HhFbfgnI5CjCuBdY58xGR9z0hTDK/V4ScYbBtWrvG0MS8FDaMU+2RVL24E9BtphLVt;4:oUrEGHbgiz0AlkLdMusfLLJgn/S6ti/qYjWmtkotwDbzD1D2uJZPyY4Sr0B9y+4Sy2cdyMxOtTdO+Y5ipRgqE91lBccrCHClVKQzO5EcZp9BeuqBhUXSBZRa1RkIxBjl+1sAtzuC2SE5N26So82SdWV0aA6b+eC8TUWs6DHIYPe+ZscSdfDcg3TM2h1/Q06TywxFZXYEAz1QReHcb8V7iErE+RS5pRAOm3yvQ0IV2jvTbBf+CPHLF0BwxfP4nW6G5fdODj/QkmQQzGIGsJyDxg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011);SRVR:DM5PR15MB1657;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR15MB1657; X-Forefront-PRVS: 05066DEDBB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(366004)(376002)(346002)(61484003)(24454002)(199003)(189002)(67846002)(52396003)(83506002)(8676002)(229853002)(305945005)(2906002)(81156014)(6486002)(81166006)(101416001)(53936002)(50466002)(33646002)(6666003)(2950100002)(64126003)(189998001)(105586002)(106356001)(31686004)(65826007)(7736002)(6246003)(5660300001)(8936002)(4326008)(93886005)(6116002)(31696002)(68736007)(86362001)(1706002)(478600001)(52146003)(2486003)(23676004)(52116002)(110136005)(58126008)(53546010)(25786009)(65806001)(65956001)(47776003)(316002)(97736004)(230700001)(36756003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1657;H:[IPv6:2620:10d:c0a1:1110::1070];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxNjU3OzIzOlp6Q0VHTkhRK2p3d25VTldiQ0tpKzJTeU9l?= =?utf-8?B?YktqZkFScTRiUlYrYzRabmhGK0ZrRmQ4aHBWWDVjcmwxL1NpZW9kVXlZZS8z?= =?utf-8?B?bTFtVXpRaFNuWE9qb0ZodGFwZEFuOXBOM3FrQmw4TFlNUFpFc1g4VTA1ejAr?= =?utf-8?B?elVCVWJBR2NROU5lZ1JUTVI5eXpscjc4VVA2TG51VVFGMlJubmxzM0ltSlVw?= =?utf-8?B?djVFRW9oT0hMam5MYVJTZWxCYzVxaUU5WUV4MzBJVzhWaDAyMFU1UHlCNWNU?= =?utf-8?B?ZUVtclVyYkRQMVQydkdUeTljRFA4UjBmMmRBOFRQZzRPM2oxdGxiU2swbHpT?= =?utf-8?B?TllHb0VGaVcwSFJyd2pUSjhKblZzZ2IxQkFFZk5ieEVCNG0yM1UrZW5zSHZM?= =?utf-8?B?RzZnTitQL1Noc1RNWG0xZnVnMkE2OU9DUkFqd1J5UWNKWHh1RHowTStLMFh5?= =?utf-8?B?VE9CZ3A4OEZFalVaWWNpQ1N1WkRXZktzcmNmaFdseFpsMS9MNVgvVWpldnBP?= =?utf-8?B?Q1pDK1hKM2hFQ0k5Z0RVeFIrNSt5UjV4VjFZUVFQdUdwL2ZRQ1VtSDA5VXhT?= =?utf-8?B?VjB6UmNnR09RMmsxVkZDSURML0orUW8vbnZxNndXdGRseU40YkpWSytqdDdo?= =?utf-8?B?WFVpc2F6aFJlLzJkajdqN2YxU3ByZEhPakdudTd0ZWNHb3BXQ1EwMmIvM2s4?= =?utf-8?B?YjlqSE5ReW82UmhyZTZEcllNbmpiRjlLNHF6VU1JRnQ4L3JKbEdWSjhVS0JR?= =?utf-8?B?Z1NXRllsS1JzcS85Z1dtVCsraFhHRkx3R0RENlhJQUNzUTlFWXJDZE5wTXlT?= =?utf-8?B?TncrNUxuNmcrdXo1TCtVbXF1UmdXcUJkdmNPdjd1cXFOVE9mTE9VQmhSSW1a?= =?utf-8?B?aEpuMk03S1VaNWJoU0o5N0pQMU5pbkVZSE41SHVWZ3piNHhBWHBva2FKa3NZ?= =?utf-8?B?ckM3SmgzVEhvdGpMc3V5NWtOdzVLY3RLWkM0b1dWU2xiSm9CVUFNcjFZc3ZU?= =?utf-8?B?bTRYRmUwb0JEN0hwWXVlOFBoaUgva1VMS0ZSRjRVbG9ldXV1eTFCMHdQQXZz?= =?utf-8?B?WEs2ZE91dDlZY01tYzNRb0h5eUxhU2FXTXUrZ0RleGEzMmNWMTVJWDZXY00y?= =?utf-8?B?N3JnOFh0V29ITkZ3L2c2MksvcFFaUXJGT0llN3IxSHFvNjU2NGtQbC90Q3lv?= =?utf-8?B?VEJTaXI2T09sSUZTUkU3aGVjY2Z0VEFEYzFKVU16MGphWUVoc0FmY0hZQmVM?= =?utf-8?B?OW55Ri9qaFpXWU85b29rZ1UxVUpNRGQrRGZvSFdPVnRIZCs0cjlPQ0QrTXZY?= =?utf-8?B?RWd0TmM1cFFxaXFhYjJwTVFrRnl1ZVoxS1JWajFIQldoUG5kS0NZNnVqQnNW?= =?utf-8?B?dUlvK3IxbHlVSmRVTGtrS2loTnNyVU1QVklwWEZYZG9XWmovOFZKSTZoeHhz?= =?utf-8?B?aCtRLzFNb2NGUmZSaG14VlBXbTNQMnRWYTVOWU92ZGVmWVFoWjJoeHJLbkJQ?= =?utf-8?B?SHNYMmpCZjhnajVTa29ES1Y0dTh6eWpkanNid0RudXZoWHZ5NHk2UzdiVjJU?= =?utf-8?B?OVVnVG5lLzFnbEpWRmFEaWlnTk8xM3lSUnc3RnkwQUg1ZkxNS08rRUV4Z3F2?= =?utf-8?B?KzhDVzRneklqMHdBOE4rbGJyeEV1cStmOXVkL1hUcXVJZDNjcmtBNFAxdVQy?= =?utf-8?B?RE15VDdFMFRIaXA4eERjOTkyaTB3eWtDUHkrSXk4Q1VDN0JNdm1ubVpzS1Vj?= =?utf-8?B?bitrd3I0N2xlZXRPa3JEcFVGamJSYk5STGNwR3Zjck1HZG8xdjlBMzRnSkl6?= =?utf-8?Q?5pesUibmowbaI?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1657;6:r38SQ/q5R5IToOHq/gT8lpqB4C3Y1He4y9OrdZgGsSAuat7JcHenfl6qnWCCjgVHc9wjButd0bQ4BmJQNn5dWxAL6Ihxze0URr0eklRWvflO1StcixE8H2HbSlvQcI35OfGgohmFz3mdZ6uMfpFWYG6muzHN3/BQ0cWbqmrJ5bXtRttm7+umBklRKS3zaAcWK7nkSWnZFe0g8RqyXGpBVntdObs01aAouhmlG6EYQZ3uyDyn6n/WlJVV/AV3gYg8pTxtLZqSZvwRu6eDiQvHbybUfuLspQikCxzNGN2MQqU8PIOvxjP65jh3yEhmGOycQm3LJXerfz4N8LoOwD9kTMceBTw8HW2IuzTAn+Rk6Iw=;5:AUNo7xmD68B9a/TMmBBVRolr0ENi1FRTuLuHtd7LFmw9Cebq6T5aooPQtlbI4P8zgzwpXEIGE5Gu+q7uUd4P1GQoW6WZYHUwb5M8NX4kJQ8yCKJ1OIEWLPbMDfWQLCMfU7h89QDFy+qhc5skm3oHaO8kXZa6+wxe7eqtEEogC4Y=;24:chalKHAbbKs2dbWoSyjr8ZkRp9TdcJa0Rqg+rSsgEjm3SmR4VLEAGz67+0S8uZr2D/HuiEtCc3n74mNWz6UGLb/hOCJEM3PFAprFUP+dQ4g=;7:ITnhndgfAvb72W4DPro/x2yioJFl59LHuCYp5OOjZQwTl4aEz2VCKaNT3mx90gtQQ/DyGL6TiyVuHGBlFlqYxBQQItPAt4Q4RpVah3UbBwMAF5P72fbla7NvopeEH6NJn898EAw3IwchWdav+T3T88cUDX7bfNEBId32G7m7zQw1OUyncuTZvUWTCYqmylpE7F432y/Lh+1iVaTlRr8PwTsa89VDIv5vkZvdGm9AwXKQRjT+EcF6TApuV/qJ1evx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1657;20:mLE9T9CYyZxAxvtgnH+w19RPOlAmQxekp7lmxV/WF4C83N2StizL+Zw6Duzbp1f6vdmy9L85N89/JEE8xFUomwWzM7F/2pJjx6O03Lj0RC9ctsN68ClSOu+8ro8itna1QGTn7pANeGxNsKacB2LppftB7VedfYQYacTpCbilhkE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2017 18:38:30.8436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14feb3ce-9e41-49ed-7210-08d537586449 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1657 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-29_07:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2017 12:05 PM, Tejun Heo wrote: > On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: >> Hello, >> >> On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: >>> What has happened with this patch set? >> >> No idea. cc'ing Chris directly. Chris, if the patchset looks good, >> can you please route them through the btrfs tree? > > lol looking at the patchset again, I'm not sure that's obviously the > right tree. It can either be cgroup, block or btrfs. If no one > objects, I'll just route them through cgroup. We'll have to coordinate a bit during the next merge window but I don't have a problem with these going in through cgroup. Dave does this sound good to you? I'd like to include my patch to do all crcs inline (instead of handing off to helper threads) when io controls are in place. By the merge window we should have some good data on how much it's all helping. -chris