Re: [PATCH 06/12] pinctrl: ingenic: use new GPIO line value setter callbacks

[Paul Cercueil <paul@crapouillou.net>]

Hi Bartosz,

Le jeudi 24 avril 2025 à 10:35 +0200, Bartosz Golaszewski a écrit :
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that
> return
> an integer, allowing to indicate failures. Convert the driver to
> using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index a9e48eac15f6..3c660471ec69 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -3800,12 +3800,14 @@ static void ingenic_gpio_irq_handler(struct
> irq_desc *desc)
>  	chained_irq_exit(irq_chip, desc);
>  }
>  
> -static void ingenic_gpio_set(struct gpio_chip *gc,
> -		unsigned int offset, int value)
> +static int ingenic_gpio_set(struct gpio_chip *gc, unsigned int
> offset,
> +			    int value)
>  {
>  	struct ingenic_gpio_chip *jzgc = gpiochip_get_data(gc);
>  
>  	ingenic_gpio_set_value(jzgc, offset, value);
> +
> +	return 0;
>  }
>  
>  static int ingenic_gpio_get(struct gpio_chip *gc, unsigned int
> offset)
> @@ -4449,7 +4451,7 @@ static int __init ingenic_gpio_probe(struct
> ingenic_pinctrl *jzpc,
>  	jzgc->gc.fwnode = fwnode;
>  	jzgc->gc.owner = THIS_MODULE;
>  
> -	jzgc->gc.set = ingenic_gpio_set;
> +	jzgc->gc.set_rv = ingenic_gpio_set;
>  	jzgc->gc.get = ingenic_gpio_get;
>  	jzgc->gc.direction_input = pinctrl_gpio_direction_input;
>  	jzgc->gc.direction_output = ingenic_gpio_direction_output;