From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6428D38BF97 for ; Wed, 7 Jan 2026 16:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767803225; cv=none; b=aPjh1ECr/cyzyINpjBU/MFL3RE7xcu8iGKBqp3AAIMGxz4Za1TRDYrykFlVLBQ8HdtZBhiC6lCahjpzfmBCjEIYv+4wQMDs/QB2sz/j3Qc5KA4yxNgD4s9xzgfLIR6zmyEJMBNLijVT5QhQgubJvxXSh4KzFHl6kTSFmBSTQ2Ks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767803225; c=relaxed/simple; bh=ocjlV2HNIOFaE2jQ+fliyYjPnubqT/6CSs4aX2Mnn8I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ALXYfHqQTsBCNC9DSVsGv+egDCYw7JZsGdkh+4wu/rY4uLtYhvShHmopIQSA0mbNczfwaqIvOF/QPWGmFXkfWTDAoDJUOHsAZPuyBSVrzR2kxxCwdodGfuBHpySebjkgMbLe2kI9e9hVuQUDBTaCTZx5PKewuI5i1OuR4QjgEnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=esLRBjqq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jYS45blW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="esLRBjqq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jYS45blW" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 607GM6tU1979976 for ; Wed, 7 Jan 2026 16:26:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d5wxY3w6nk1EMOzJrQAcU/6BJWx1PGSRo+JS7Wyl/dA=; b=esLRBjqqLnzL1eWg btTcXwq6QWcEVWyXOuxTHoX6LNhhS5pZeIM/n3RKsSCnnmE6syAb9UNvN1EiKz5W 5GAb29vWcPaGoMJ3xOAjFh3aVITPxIRlrEdjeix3HgIb754PGnY4+3/2KiTi5XR7 +y+QG9EHAWI6xlPUWQ04Nyob7yE5Irt608LxWsSJFwKfdrsprL49m7sQgp6R5hQo /RpgVL4Ci2GEgzU7vVDC3owtCvqT+1ssM4wO+85VqWnudolMfWl0aj5MPw6LC+DS qQeI7K93AJSQ+5uYdqm3ns4WURb/f9OYq483Hlr5IoWNgrHFPiTB26cvh1RlnUvB cyAb0g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhdavjsmd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 16:26:49 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a0c495fc7aso26424735ad.3 for ; Wed, 07 Jan 2026 08:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767803209; x=1768408009; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d5wxY3w6nk1EMOzJrQAcU/6BJWx1PGSRo+JS7Wyl/dA=; b=jYS45blWJHn+5/s2iqs/E7x5FRg/8aIPtR5/3JkDNyzuVmXzU6FVTwp3Wzo6o4ss1u 72JbMN/zKbrhOg7gjXEZ+TPwPv8i5NzB3Pc9o39fEl8s3gkuEUb+O+mfHCzAth5iULgV Iss8ED0Bz+rZaCBReJb1vsnP/sb0UxaIkbIZ60wcctN9vBmfwfLku13qjDXDH01j2HOs wk8MPqtXCqd8NQtYPB+sqoW+YLzK9V2W3TGi++bBk1BhuAxvrrN+nFD4zdcq8sh6+6Eb ua8P51UmHeSf/jfO3CyW9S2Cfjct/62aNo6C6tyVRier+StQOWCHZJwDIjnktvSckVck u31g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767803209; x=1768408009; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d5wxY3w6nk1EMOzJrQAcU/6BJWx1PGSRo+JS7Wyl/dA=; b=qqXgItJaa5hRaGVSMFLjN+BddAIkIPeIufZDafiE7qhYaQbjddO51hza34zNKPnzNN 9dIYRitG3sm0CHYxnv9xFJTAEFvlGT3hcv1CWBjZto5xDjLXqKHKgY4WzdwAKswDclA1 cEnnaW3UjrQBOyawJuDvfTziNVKvON01e7pzQ6C2a1YMgZRE6VvRLxrouQ9Npsc9ttv6 K+WxbS3pnZHC5afTkw84+vBXNwZ+cH99iWFtZqk8ebi+mIzKna5ItBksZez008PTL+XG 3Adw/DNpFs506Dvsbr95aIsJvAqLMIHApaRBBl/4xqXfIrfkpx5qmhKyoNHl+aQlcCpU sbFw== X-Forwarded-Encrypted: i=1; AJvYcCVnYyYDwSYk2bC+0WtWCVV48JfmctEvfwZR5TzEAXmyerANeOQTCbDxac1D+Pib2nnfEUpRAFWio2GJxrc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6pck/ekUoVcnO0WxY1SJtCZRzKoyVAYDIOfZEpCpjRSbTE9Zu BgvurmeFU+6wCTxcTMt4voAOmKt48oPojfz0PymSYCIgiaRlcVXEKlaQY3KRl1uBkmv9cbZWcde SWedq5erfbR0LmK/ttFudKkQFf78+07qvvQ8EzIMpvggBaEzIWFvRj1u5QxM6OB162z8= X-Gm-Gg: AY/fxX6CpvqojTF2D+JoXgEPvOcqfvtJg/aDCJwqIHvR0MmNWCAn7/fCs89u4/SQ3dc QncgBSaz07z8m2XNxQ9QYraJRIfwkEJ2u6iVH41MvzBq/FzrzG2c1a9huZjYvnoDaD4g90SLQnC Q2f5ifIvjzkQNBQF2hkvp5NSQZa6E7DD8deBuDdoBIuYPl0S3wnAkqPVze5BxOWCzP2j+PsG8Et r7bQga3XrOcQ/zKAVdNXd39kHl2j3DyEGLJvOB/WHjrm077wjYES99RUy3oQ7OdKBRfj8EDrJPM 1okVwqPXzFRHCjwnYR8oEQc2ek2OmSHBCCjFZ4XStkWLOxdLb8q8H0ZqDolNYoVnn+atIenx9At GHu+xPOOOS75vvGJ6HgaSVz/ddA66q3guugCu1w== X-Received: by 2002:a17:903:b07:b0:295:b46f:a6c2 with SMTP id d9443c01a7336-2a3ee4aaebamr26013485ad.37.1767803208641; Wed, 07 Jan 2026 08:26:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhDyZ20m0wTcSTXbF6lfqRcelUkGiEtoEtFdPGDtyUaLrGrVdvkZP+XFYxhXeMEZoWEcVI0Q== X-Received: by 2002:a17:903:b07:b0:295:b46f:a6c2 with SMTP id d9443c01a7336-2a3ee4aaebamr26013275ad.37.1767803208116; Wed, 07 Jan 2026 08:26:48 -0800 (PST) Received: from [192.168.0.195] ([49.204.25.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2df6sm55741685ad.61.2026.01.07.08.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 08:26:47 -0800 (PST) Message-ID: Date: Wed, 7 Jan 2026 21:56:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] clk: qcom: dispcc-sdm845: Enable parents for pixel clocks To: petr.hodina@protonmail.com, Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Michael Turquette , Stephen Boyd , David Heidelberg , Taniya Das Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, phone-devel@vger.kernel.org References: <20260107-stability-discussion-v2-1-ef7717b435ff@protonmail.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20260107-stability-discussion-v2-1-ef7717b435ff@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDEyOSBTYWx0ZWRfX/UUw+I6NpT20 DejfPJN/Ekgp5353DHiokov7PGrL0C4ss89pM1g8ixaTH4D3+MwSLvIa7ikL4Hg1KwTsyu49DV3 1+LPHV5gTsH6F3/Y3ti0DGjB+wjpSuySzaUqdozjsd31JJ/3gr13ssdiS4myRQm5v2TdrcifyB7 /9C6PsNoG034kAR5py41MLIrVgHRF1N2DsvCfvPWmoOKx/rprT5ctIkgW+hS7TgYtl5oXYh1MZD sgrYwqRUT26u4yqbNi2ba+e2KxZMJbWPhej5ORuASFYst+0IbGLFkZnf+v+vyJIe2f12Lv/yM3z /8FaWQ8dxArW7IytkXLKeb4QD9eFXym1mmyDZcGAyP/pOkgRRC58KrPdMkVF/q4voNIohWD2DYG +l8KJXSyFjhNUz9fUYZ0qhLSTXyWtZl4SXmxlCvCaCiRLZ5YWDqKSlI3uYk6V7WNSICgzaJ6NWl 0ZIvgvCcsWH7TwvsXaw== X-Proofpoint-ORIG-GUID: t9O77BfWwcMSupgyZX3rRNE3Tsg6O33m X-Authority-Analysis: v=2.4 cv=comWUl4i c=1 sm=1 tr=0 ts=695e8949 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=9zcPrCpDFr6Yft4RwatP3w==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=sfOm8-O8AAAA:8 a=fry8jdqtyFT-MZpSCxoA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-GUID: t9O77BfWwcMSupgyZX3rRNE3Tsg6O33m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_02,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070129 On 1/7/2026 5:14 PM, Petr Hodina via B4 Relay wrote: > From: Petr Hodina > > Add CLK_OPS_PARENT_ENABLE to MDSS pixel clock sources to ensure parent > clocks are enabled during clock operations, preventing potential > stability issues during display configuration. > > Fixes: 81351776c9fb ("clk: qcom: Add display clock controller driver for SDM845") > Signed-off-by: Petr Hodina > --- > We are currently running the latest linux-next snapshots (next-202511* > and next-202512*) and have encountered random freezes and crashes on the > Pixel 3, as well as crash dumps on the OnePlus 6 and 6T. > Are there any changes between next-202511* and next-202512* on the display PLL side which is causing a side effect on the pixel clock(pclk)? > This commit fixes the stability issue. I've checked other SDM dispcc > files and they also contain this configuration. > > For safety I also set the configuration for `disp_cc_mdss_pclk1_clk_src` > though it should be sufficient only for `disp_cc_mdss_pclk0_clk_src`. > > Kind regards, > Petr > --- > Changes in v2: > - Remove commits from v1 and introduce proper fix. > - Link to v1: https://lore.kernel.org/r/20251213-stability-discussion-v1-0-b25df8453526@ixit.cz > --- > drivers/clk/qcom/dispcc-sdm845.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/dispcc-sdm845.c b/drivers/clk/qcom/dispcc-sdm845.c > index 2f9e9665d7e9..78e43f6d7502 100644 > --- a/drivers/clk/qcom/dispcc-sdm845.c > +++ b/drivers/clk/qcom/dispcc-sdm845.c > @@ -280,7 +280,7 @@ static struct clk_rcg2 disp_cc_mdss_pclk0_clk_src = { > .name = "disp_cc_mdss_pclk0_clk_src", > .parent_data = disp_cc_parent_data_4, > .num_parents = ARRAY_SIZE(disp_cc_parent_data_4), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > .ops = &clk_pixel_ops, > }, > }; > @@ -295,7 +295,7 @@ static struct clk_rcg2 disp_cc_mdss_pclk1_clk_src = { > .name = "disp_cc_mdss_pclk1_clk_src", > .parent_data = disp_cc_parent_data_4, > .num_parents = ARRAY_SIZE(disp_cc_parent_data_4), > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_OPS_PARENT_ENABLE, > .ops = &clk_pixel_ops, > }, > }; > > --- > base-commit: f96074c6d01d8a5e9e2fccd0bba5f2ed654c1f2d > change-id: 20251212-stability-discussion-d16f6ac51209 > > Best regards, -- Thanks, Taniya Das