mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
	Rob Herring <robh@kernel.org>
Cc: agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	gregkh@linuxfoundation.org, catalin.marinas@arm.com,
	will@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de,
	geert+renesas@glider.be, neil.armstrong@linaro.org,
	nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl,
	quic_srichara@quicinc.com, quic_varada@quicinc.org,
	quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Date: Fri, 23 Jun 2023 10:08:26 +0200	[thread overview]
Message-ID: <fffa4486-1f76-f7e3-2bc9-21dbe40a606e@linaro.org> (raw)
In-Reply-To: <20230623054508.GA13261@varda-linux.qualcomm.com>

On 23/06/2023 07:45, Varadarajan Narayanan wrote:
> 
>>> +
>>> +description:
>>> +  USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.
>>
>> Where's the IPQ5018 compatible?
> 
> In the previous version had a default and IPQ5332 specific
> compatible. IPQ5018 would have used the default compatible.
> However, in the review was asked to drop the default compatible.
> Hence planned to include ipq5018 compatible and post it in
> separate patchset while enabling IPQ5018 USB. IPQ5018 init is
> also diffferent from the init used here.

Your previous patch did not have ipq5018 compatible. There was nothing
indicating that some default means ipq5018...

Best regards,
Krzysztof


  reply	other threads:[~2023-06-23  8:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  6:22 [PATCH v1 0/6] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-06-22  6:22 ` [PATCH v2 1/6] dt-bindings: usb: dwc3: Add IPQ5332 compatible Varadarajan Narayanan
2023-06-22  6:22 ` [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy Varadarajan Narayanan
2023-06-22 14:46   ` Rob Herring
2023-06-23  5:45     ` Varadarajan Narayanan
2023-06-23  8:08       ` Krzysztof Kozlowski [this message]
2023-06-23  8:08   ` Krzysztof Kozlowski
2023-06-22  6:22 ` [PATCH v2 3/6] phy: qcom-m31: Introduce qcom,m31 USB phy driver Varadarajan Narayanan
2023-06-22  6:22 ` [PATCH v2 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-06-22  6:22 ` [PATCH v2 5/6] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-06-22  6:22 ` [PATCH v2 6/6] arm64: defconfig: Enable M31 USB phy driver Varadarajan Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fffa4486-1f76-f7e3-2bc9-21dbe40a606e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nfraprado@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=quic_varada@quicinc.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=rafal@milecki.pl \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®