From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0362C2D0BF for ; Thu, 5 Dec 2019 23:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8251C24658 for ; Thu, 5 Dec 2019 23:17:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="cC1QZ33w"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="glsgjMMV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbfLEXRo (ORCPT ); Thu, 5 Dec 2019 18:17:44 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:33479 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfLEXRo (ORCPT ); Thu, 5 Dec 2019 18:17:44 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id F25596056; Thu, 5 Dec 2019 18:17:42 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Thu, 05 Dec 2019 18:17:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=D8lbGIlMZ18hLjs6+rXC0nkBXoWutq8 kGyoDAM61WFQ=; b=cC1QZ33wwhO3ON234cJV7WeWKsjQsu3AM+62O/5yn+hQu0c uKzptXAbSTjvzvMMqmjq0t0jqmIr1TN2hvQyLNrPZgypFJNHaFGVhLk4Fj6o5RvX RDxZw8Wd64PPWtH73pOyMVMQg9WkV86kuswV6kdTtr8PMKbRNU22FBkE59wUublR 0z2k1NnO9LVLgGPWmPScrsOBVLr2ppxLbaOBpFBhQmmqvJb5L7BwXQRCM3NUT3qE BkuzaLgGJwXm5sqrnK13iXJLq8awORQ+ANfaljvZeg3TG6FNYREOH7nqetHoVoyK k5FtRzsCDtvVwaTD0HXBVOLvX/Hkz9dv/wQKaiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=D8lbGI lMZ18hLjs6+rXC0nkBXoWutq8kGyoDAM61WFQ=; b=glsgjMMVtVu1GYFVEeFa/P nQew7jllOtDaWL3IBMHyiJul+mnzAP01MCA5EqEhymmJi0GymZ56t46bj+Afo3RT KOYK3pTGNNUJRYrIUmvrwPhPR/BQ+epM1gEmgvyzynD+H47qOnLgDuUXtRqCoRKD onnoXUj9PdzZykhUFwWRgUy8cQFHI8FVuB/sbswBBtyv2KXiUx4A+2XzGdIf+LdT DCPIzS8EnpDrfPf3PwTnLN6evbTg+pD9o7e5Wp17nFYIrZfBhiBdYt4fDRKgO2S8 xktZkDj4L5vWiwMtOrVeiALV+6fQJgbORSHUSbsn+CPLfvfV20iO9Utjg/apuP8w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudekuddgudejvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrg hrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 04541E00A2; Thu, 5 Dec 2019 18:17:41 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-612-g13027cc-fmstable-20191203v1 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <3da2492c244962c27b21aad87bfa6bf74f568f1d.1575376664.git-series.andrew@aj.id.au> <40d554c0-de62-4d45-bbcc-dd3a3aa12a65@www.fastmail.com> Date: Fri, 06 Dec 2019 09:49:04 +1030 From: "Andrew Jeffery" To: "Rob Herring" Cc: openipmi-developer@lists.sourceforge.net, "Corey Minyard" , "Mark Rutland" , "Joel Stanley" , "Arnd Bergmann" , "Greg Kroah-Hartman" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-aspeed@lists.ozlabs.org, "linux-kernel@vger.kernel.org" Subject: =?UTF-8?Q?Re:_[PATCH_1/3]_dt-bindings:_ipmi:_aspeed:_Introduce_a_v2_bind?= =?UTF-8?Q?ing_for_KCS?= Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Dec 2019, at 04:20, Rob Herring wrote: > On Wed, Dec 4, 2019 at 11:12 PM Andrew Jeffery wrote: > > > > > > > > On Wed, 4 Dec 2019, at 01:01, Rob Herring wrote: > > > On Tue, Dec 3, 2019 at 6:36 AM Andrew Jeffery wrote: > > > > > > > > The v2 binding utilises reg and renames some of the v1 properties. > > > > > > > > Signed-off-by: Andrew Jeffery > > > > --- > > > > Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +++++--- > > > > 1 file changed, 14 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt > > > > index d98a9bf45d6c..76b180ebbde4 100644 > > > > --- a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt > > > > +++ b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt > > > > @@ -1,9 +1,10 @@ > > > > -* Aspeed KCS (Keyboard Controller Style) IPMI interface > > > > +# Aspeed KCS (Keyboard Controller Style) IPMI interface > > > > > > > > The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs > > > > (Baseboard Management Controllers) and the KCS interface can be > > > > used to perform in-band IPMI communication with their host. > > > > > > > > +## v1 > > > > Required properties: > > > > - compatible : should be one of > > > > "aspeed,ast2400-kcs-bmc" > > > > @@ -12,14 +13,21 @@ Required properties: > > > > - kcs_chan : The LPC channel number in the controller > > > > - kcs_addr : The host CPU IO map address > > > > > > > > +## v2 > > > > +Required properties: > > > > +- compatible : should be one of > > > > + "aspeed,ast2400-kcs-bmc-v2" > > > > + "aspeed,ast2500-kcs-bmc-v2" > > > > +- reg : The address and size of the IDR, ODR and STR registers > > > > +- interrupts : interrupt generated by the controller > > > > +- slave-reg : The host CPU IO map address > > > > > > aspeed,slave-reg > > > > I don't agree, as it's not an aspeed-specific behaviour. This property > > controls where the device appears in the host's LPC IO address space, > > which is a common problem for any LPC IO device exposed by the BMC > > to the host. > > Then document it as such. Common properties go into common binding documents. Fair call. > > > > > Example: > > > > > > > > - kcs3: kcs3@0 { > > > > - compatible = "aspeed,ast2500-kcs-bmc"; > > > > - reg = <0x0 0x80>; > > > > + kcs3: kcs@24 { > > > > + compatible = "aspeed,ast2500-kcs-bmc-v2"; > > > > + reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>; > > > > > > What are the other registers in this address space? I'm not so sure > > > this is an improvement if you end up with a bunch of nodes with single > > > registers. > > > > Put into practice the bindings give the following patch: on the AST2500: > > Okay, that's an unfortunate interleaving, but seems fine. "Unfortunate" is a good description for the entire register layout of the LPC slave controller. I'll send a v2. Thanks, Andrew