From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E88F171E7C for ; Sat, 2 Nov 2024 09:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730540202; cv=none; b=SgWkpVhJoj0tETGnlKp489ZsfkOvhhR5SDjWphG02nXglhTF37QKkEnF8GxOL8iHBXlyhLawVWab/T3rZo4SA1cIt63ltpoumV3vwsob+5r2qMQPNIj7LXTZw7j1rj5QZnEbAPnTv7D5Fit74hv+ttbLNjd4P5AWkG8AOQBy6H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730540202; c=relaxed/simple; bh=Cx0/s3T64MtFBPK/EzjOE4Oh0d8RoAs+/LlAbuNrlGo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ka8rAt6mrVs0HCjX6xVrdwb3xFRrpWBjS3eKL0IY5qjDf4cX/UK6t6pAxcNTpFAc4YFWjnernxY4/Wj01TtVB/DIpTg+zIy6euMYwLW2A67ALxAn2YPmphzkaeqP0Gkkb+3qHARnwARpIeDwXmfSvuJXGEtOqyyFwzXsNVrToLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xk0Geu1C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xk0Geu1C" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A24P2Ad030622 for ; Sat, 2 Nov 2024 09:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y29GH5vL6Son0tb25oXfDxF5f1oIYnsxUcrvGbyq8VQ=; b=Xk0Geu1CeiQW1ndf Pn9GI2w1MxAJ3FOx1FxiXJLrMo/GWN9TR7mN0OvvekYBAphxktXPhuUGAy1j4zQH j93RFiOFVrQkIpMxWXXK0DOcBGIEs7cAAn2o7UFmNo4XEVL4YfJUom1m9AT4O3oX ul0pOKwPFCoFyUtP5ba+NihPZI7StxQh/q+Am02O2yQUS3PJBgPtxv11j++JgeGV iRSm6pahuuMNEjmBKrzS3gmHVv0gbcEqlZXPuoOnsxLIRpCGJ8f8Fx7jY+v7x+sD gPVE7eKH4lRwkwVg6Bd087wmYQzwQWWkMjsQwWJPkSAOGRIQfeUDLMdAHAQbpKs2 d7uSIg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd1fgdy7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 02 Nov 2024 09:36:40 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6cb9afcecb9so8448496d6.1 for ; Sat, 02 Nov 2024 02:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730540199; x=1731144999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y29GH5vL6Son0tb25oXfDxF5f1oIYnsxUcrvGbyq8VQ=; b=LvRX0SAALRFFu1BfCPbrAbEvDJSbHa4QkntQ3V0k0Oz42fQb+ud9Tr0NfoB5nDRuph B3PhTIxnzCc6WnBR6+sMcGaWg/EkFeVorK9KVpAyFf6iYhiuUeBgZ0oqSzlkrlRfiL8G iYuztlo6IXj2mLrNHRmNosX3c+vf6eLiB6F86vCQuvBGO7cDkMCwgLlTRyc4hk+8N0MP ceJUzxuIeEkbKD12fyRU84BIrUlRY6Y8wJ9YPfgIIZ9cCAV++lB5yAho1ZejvWEMrPi7 U54Tah5hb70wV0hJJo4P7l+lwkNzovv+mus8ggrBlEVhJAv0pZLf2eCUCSuqw/otkZda GJdQ== X-Forwarded-Encrypted: i=1; AJvYcCVGoZRdzNWLSthreq5x/kYJyQsKg65190vwbZ39A7taBlEPjlfAw5BaE0Bhi+qa2ZY4STw3ZTmiu6cS2gA=@vger.kernel.org X-Gm-Message-State: AOJu0YyBzzm8jkDFr97rqYRk+o7JB67pLuNnbJLq+9dzNEBskAzIFTCk u3aaba1xCFwTKib1x4+qGOJz1B0dty+zwNMNYz3K+FZ0AWBm7fcdjcgOMQ0rpDxXQoIyETgETr9 WUZN9y8CwJa+/5PVtod6gXuAF3Nkjvzp7SK4JjyXuFbqTJ7Og8vsKwOniQOhmUdg= X-Received: by 2002:a05:620a:45a7:b0:7a9:a632:3fde with SMTP id af79cd13be357-7b193f6ff70mr1685019785a.12.1730540199396; Sat, 02 Nov 2024 02:36:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwQP7gofFmY9sgxMvy+PKIDrsRwoGI7xSwcZsJP6aZF/ePuF6h/5RYlGz0LMgoXkLvUqmbEw== X-Received: by 2002:a05:620a:45a7:b0:7a9:a632:3fde with SMTP id af79cd13be357-7b193f6ff70mr1685017785a.12.1730540199014; Sat, 02 Nov 2024 02:36:39 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e566442easm290268466b.166.2024.11.02.02.36.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Nov 2024 02:36:38 -0700 (PDT) Message-ID: Date: Sat, 2 Nov 2024 10:36:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] dts: qcom: Introduce SM8750 device trees To: Melody Olvera , Konrad Dybcio , "Rob Herring (Arm)" Cc: Arnd Bergmann , Dmitry Baryshkov , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Satya Durga Srinivasu Prabhala , Trilok Soni , AngeloGioacchino Del Regno , Neil Armstrong , Lee Jones , Konrad Dybcio , Conor Dooley , Stephen Boyd , Krzysztof Kozlowski , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Catalin Marinas , Geert Uytterhoeven , Will Deacon References: <20241021232114.2636083-1-quic_molvera@quicinc.com> <172978739477.623395.5604249801475913676.robh@kernel.org> <3ca1f7e8-1204-4898-9e7e-cb6423c122cc@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: fb-Lh2E4L0vF_zB8aVZgnYvTP_-rrqO1 X-Proofpoint-ORIG-GUID: fb-Lh2E4L0vF_zB8aVZgnYvTP_-rrqO1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 mlxlogscore=961 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411020085 On 25.10.2024 12:46 AM, Melody Olvera wrote: > > > On 10/24/2024 10:22 AM, Konrad Dybcio wrote: >> On 24.10.2024 6:33 PM, Rob Herring (Arm) wrote: >>> On Mon, 21 Oct 2024 16:21:09 -0700, Melody Olvera wrote: >>>> This series adds the initial device tree support for the SM8750 SoCs >>>> needed to boot to shell. This specifically adds support for clocks, >>>> pinctrl, rpmhpd, regulators, interconnects, and SoC and board >>>> compatibles. [...] >>> arch/arm64/boot/dts/qcom/sm8750-mtp.dtb: rsc@16500000: 'power-domains' is a required property >>>     from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpmh-rsc.yaml# >> This I'll address when reviewing the dt > > So for this, let me know if the following seems about right. > The rsc node needs a system-wide power domain defined. To accomplish this, I would define > a system_pd node and point both cluster pd nodes to it via power-domains, similar to what you did here: > https://lore.kernel.org/all/20240102-topic-x1e_fixes-v1-3-70723e08d5f6@linaro.org/ > > Then, extrapolating from that, I can define a system-wide idle-state under the domain-idle-state node as follows: > domain_ss3: domain-sleep-0 { >     compatible = "domain-idle-state"; >     [...] (omitting a bunch of details, but you get the point) > }; > > And then point to that from the new system_pd node under the psci node: > system_pd: power-domain-system { >     #power-domain-cells = <0>; >     domain-idle-states = <&domain_ss3>; > }; > > And then of course in the rsc node, have power-domains = <&system_pd>; > > Is that correct? Yes, please go ahead with this Konrad