mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PATCH] driver core merge for 3.3
Date: Fri, 13 Jan 2012 20:03:04 +0100	[thread overview]
Message-ID: <gid3ane87r.fsf@mx10.gouders.net> (raw)
In-Reply-To: <CAPXgP120MoEUK9vSiELx4nzkL9X3w=YBgXGs3Q-VPm-4ZjgvZQ@mail.gmail.com> (Kay Sievers's message of "Fri, 13 Jan 2012 02:39:27 +0100")

Kay Sievers <kay.sievers@vrfy.org> writes:

> On Fri, Jan 13, 2012 at 02:11, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> Hmm. I think this is the cause of one of the suspend/resume problems I'm seeing:
>>
>>   Device 'machinecheck3' does not have a releae() function, it is
>> broken and must be fixed
>>
>> that's the WARN_ON() in drivers/base/core.c (line 192), and it comes
>> from disable_nonboot_cpus() doing the whole device_unregister() thing.
>>
>> Afaik, it's arch/x86/kernel/cpu/mcheck/mce.c.
>
> I guess this kind of warning just did not exist for the old sysdev
> devices. The 'machinecheck' devices are DEFINE_PER_CPU(struct device,
> mce_device) devices, so we will probably just add a dummy release
> function, which might not fix the problem you are seeing.
>
> Maybe you can check if the suspend problem goes away if you disable
> CONFIG_X86_MCE?

Hello,

three days ago I also reported about a suspend/resume problem and
disabling CONFIG_X86_MCE also helps on my machine, although I did not see
the above warning in my logs.

Dirk

      parent reply	other threads:[~2012-01-13 19:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 20:11 Greg KH
2012-01-06 21:38 ` Geert Uytterhoeven
2012-01-06 22:06   ` Greg KH
2012-01-06 22:31     ` Ben Hutchings
2012-01-07 19:29       ` Linus Torvalds
2012-01-13  1:11 ` Linus Torvalds
2012-01-13  1:39   ` Kay Sievers
2012-01-13  1:46     ` Linus Torvalds
2012-01-13 18:24     ` Greg KH
2012-01-13 19:03     ` Dirk Gouders [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gid3ane87r.fsf@mx10.gouders.net \
    --to=gouders@et.bocholt.fh-gelsenkirchen.de \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome