From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A1D352C54 for ; Fri, 14 Aug 2026 17:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786729589; cv=none; b=jiMIdeQvbgPkCVRTVRHQoRRO+oeHlI1dwl3DY1qyD3tDJ1WfS+bbe+04p3NPV5vEoDdhtlMwHM4chjAGBd/xSEd2gK/S6GnI19EcyJWBU1YA7Q5Vq3PLr2fdQzA79KjNdV4IMkZAWn4hG3FVon6XMsaHRq9SC6j+uMlgqUTlbqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786729589; c=relaxed/simple; bh=pHQHDxbUgUXawpMBwNmBaKB96flhW2yqXf2kNVAMug8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cUkx4g8aY4yjGFExR8yRfq/BtVIrMKDlh2w9V9pKQD/nFaZebzEs57bRiBxm1CUYFQb+Cw90dM/rl4l/kAJedvWOqw8/atFOTfgv6xWfKmrJ97SyFzr2tCceoDZC4bPbKiyLXzY6LRSeWp1thRU4jMm5u5x/OZh9N/nE+E61zxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pT6ED4Tu; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pT6ED4Tu" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-472326ca506so871423f8f.2 for ; Fri, 14 Aug 2026 10:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786729586; x=1787334386; darn=vger.kernel.org; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=i1r2xPJfkJhEKLocmkcDET9WPaG8FwcMD2/2OeeTJFY=; b=pT6ED4Tu7+iEGW0cmYvc9QJe7ANILzoGArP6yV+EaFqeNweV2SQYACOnyvO3ffgW8n aK5n4PX5AOVeW1C+Ggb11FMlEor9z4dHgk8h/9nkvtQbH7iac2mKuw5SH3snt/F6aSVj vBBMeSgyuYwbMDBBobMq0/iT5d/vGutKsFTYHtPd9QfRmbblt5VT5oRx27DrVZkaKqQc SET/niXwxhIP4rHANPd8G71UbI2bMsVZdraZOZABpp1bX1tUeIhORgayifIdM6NjmbDs FvBpmfX5R/zUtzIrYg4Ou89HEna9Q49R6TT1h0qI/ZZHGdMmssZ9oRJKpmDV+tKVbGxN /xyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786729586; x=1787334386; h=content-type:mime-version:references:in-reply-to:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=i1r2xPJfkJhEKLocmkcDET9WPaG8FwcMD2/2OeeTJFY=; b=HNgP7uB/G5xfKrtvPpZ3VvxVDgVgCKg8IdPPkVdvBjjgXG/GevhZsKTm7o42wRdzPV paWcs3H13SFaKbFofrywb2cG+3Zj5AAkXflMhTVBsKZ5rEXeC6vdWN1k9h9KINoVUNOj yhUn8z8Tx51OHBSsT/THiWRJ4qIihEimSc4YujEJHbGoUYC+MSWrloES98xnN7RWUE3N CVrWAG9C95ejEn/nYyS3rloR8aOmWFvVJTaFgO7Dw/EtzlG2jNRPIcohICZafHzGLx7v kBP/QR+jiEy8PlZAN/+nxNqOM7SOBAcizdWspQ76WObRxwoqxoZpQ423y0ENKQZ8PPM6 ClLA== X-Forwarded-Encrypted: i=1; AHgh+RoJ6+cwSjdiGcOQYICtVx6zZ4HYneCIPyEe9cRpcABZB4bPJeh52/e3obNzJnZI/tPBPD9yo4GoeIeI67w=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ9bv6YPAzavRK8v/0/DcYeGlx1z0F1ChgGqHOkQKc2XhIfoAt EMDZAiPXIAb0KHrMwHj69QTMLx9lRDbgQp++fZeSYh4q2K1kdW8LqrKjwyeR+aWkibWCag== X-Gm-Gg: AR+sD10Cw7mWVMLSL7Cukq6kOGZGgLC0esPQbkeWxVF1ziHIqDWjjAvH3EC1AOo9lU4 2OowwR52VCrUV3bDqYLdf5N42a7AI81qcyqhD9bb9PWs+8Z7azBtjoDMxV6HLwaYCwZOpxH40RQ z4Ki51o7R5qPuCnYvXPo/VNXmvX1z8gGNDrLddXFGf/aS87Hdxsp4FkCvJBttAt4I6Ct9X1KUq9 OlkKiwTP6HXOwsUqIjjp0Wln2fZKBZkK+9LxElKFd3wFw66KaazzF0PNb/MthJbGQNCITxt0Cz1 NWd1AAmMuH1mVqbUrfg/UXfckxUeJfT9+KYxqwaxht38AjIPCzsrBoLShJFcbmH3rzdQ2np9CEG VvkS6+sWNzfsLrf16ERpqeMgyniCZflEsPQQ3GdCQ8KiABnmf+XucSZ2lj85HO8PkbeXVlM9gNo ztVgpnlQ6+jsVnNtKpwhbsnRsG4BHTdt+zyHHvtqTHFoJyM64o7T9+Ft4qaUpU47S5k9qzx2cHq M64OPeCUE8= X-Received: by 2002:a05:6000:2087:b0:47f:96e6:70a with SMTP id ffacd0b85a97d-481606bcec4mr8999132f8f.0.1786729586010; Fri, 14 Aug 2026 10:46:26 -0700 (PDT) Received: from strix.localnet ([197.250.226.224]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219d3dsm10124274f8f.14.2026.08.14.10.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 10:46:24 -0700 (PDT) From: Stefan =?UTF-8?B?RMO2c2luZ2Vy?= To: Lee Jones Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Brian Masney , Vinod Koul , Neil Armstrong , Russell King , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, mfd@lists.linux.dev Subject: Re: [PATCH v10 04/12] mfd: zx297520v3: Add a clock and reset MFD driver Date: Fri, 14 Aug 2026 20:46:11 +0300 Message-ID: In-Reply-To: <20260812131503.GR1072730@google.com> References: <20260810-zx29clk-v10-0-63846490712c@gmail.com> <20260810-zx29clk-v10-4-63846490712c@gmail.com> <20260812131503.GR1072730@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextParthu9EI7NhQy6giXCUf6L9sg"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextParthu9EI7NhQy6giXCUf6L9sg Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Stefan =?UTF-8?B?RMO2c2luZ2Vy?= To: Lee Jones Date: Fri, 14 Aug 2026 20:46:11 +0300 Message-ID: In-Reply-To: <20260812131503.GR1072730@google.com> MIME-Version: 1.0 Hi, Thanks for your feedback! Am Mittwoch, 12. August 2026, 16:15:03 Ostafrikanische Zeit schrieb Lee Jon= es: > > +config MFD_ZTE_ZX297520V3_CRM > > + tristate "ZTE zx297520v3 Clock and Reset Manager" > > + depends on ARCH_ZTE || COMPILE_TEST > > + select MFD_CORE > > + select REGMAP_MMIO >=20 > Is this used? Thinking about it: Not in the way the build system cares, so I'll remove it. The MFD child drivers call device_node_to_regmap(dev->parent->of_node), so = a=20 MMIO regmap gets constructed for the MFD parent. But since the calls are in= =20 the child drivers, REGMAP_MMIO shouldn't be needed to build and run this=20 particular driver, and the child drivers enable REGMAP_MMIO on their own. > > + * Copyright (C) 2026 Stefan D=C3=B6singer >=20 > Personal copyright, are you sure? >=20 > Is that okay with ZTE? I'm not affiliated with them. This work is my personal hobby project to hav= e=20 some fun and learn things. I'm not copying code from their kernel dumps either, the quality of the=20 drivers there is pretty atrocious. If ZTE wants to have copyright of the upstream drivers I won't stop them fr= om=20 doing the work themselves :-) > > +enum zx297520v3_parent_type { > > + ZX297520V3_INVALID =3D 0, > > + ZX297520V3_TOPCRM, > > + ZX297520V3_MATRIXCRM, > > + ZX297520V3_LSPCRM, >=20 > None of these are readable. I suggest you improve the nomenclature. I saw that most existing drivers use "undecorated" device names, i.e.=20 "TOPCRM", "MATRIXCRM", "LSPCRM" in this driver's case. I am concerned that= =20 "TOPCRM" is generic enough that a (future) global header might define a mac= ro=20 or enum value with that name, so I opted to semi-namespace them with the So= C=20 name. =46ollowing the example of max*.c, what do you think of TYPE_TOPCRM,=20 TYPE_MATRIXCRM etc? The rest of your comments are clear to me, I'll implement them in the next= =20 submission. Cheers, Stefan --nextParthu9EI7NhQy6giXCUf6L9sg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEQxb0tqoFWyeVMl1sPRO8yFRPGiIFAmp/VGMbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJED0TvMhUTxoiPokP/iptbRf3/QgYkQF1HNMx 5pOuSmrcFnzvT8WG+mpgA+2uorsOmUfPhxRF+BA9CgOgazibEyWWETdrkvPHy+/f See03pTw5mH4LSt90AOqFDCck47OmmAfzY3AP48o61IR47EiB5eFxf0r1S35tYuE ms1C/2a98Rw60mw+eFUz3iBHWOI5fX2+DXZjOaEf/Q7d5KsZyiHOg5QUop8bsmCh YRKrMdRwLIbT8nZQyEwLiMJlFGvzdDrZc2Vo39rsPFrRjP+FZGvUc7YIymjWXYi0 m/GfFV6RQSmxxph+zLCnYfoG2MeHDc+ihgBRACTeYXy3B6FbOUNVfsCB3ENvw/4K P+OhBdxhxSIswe5KMDR1zUAeCQfNCsnrzXlLyhMxuFm1VwgzA/DJOucR96rj69hl Cne8/8AqirlMgKLNek1Fsze0DkKuxOLMsrDVHYTvlMMt/giA0EtsoQT9iNp7z0Q0 /dqmTve95/f18m4sorji135TkTiEpmYTdtn1FZVY/2/aUD4z907S7mAomm7kYviq jIesXSWzh9SFfRugYKDWsk9AqiP7Av77bafFuLzpgQ5MBnsDPpYTdCZR0ngLaP3F phrCAX4IayRFni2+kBYkRMgaGosJolehc+mC04px0CwobqERnJGQGlVbRvuPYVJv jL7hUaUKDj90M7cPPNEtjQf9 =kRv0 -----END PGP SIGNATURE----- --nextParthu9EI7NhQy6giXCUf6L9sg--