From: Anton Arapov <aarapov@redhat.com>
To: James Pearson <james-p@moving-picture.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Guy Streeter <guy.streeter@gmail.com>,
James Pearson <james-p@moving-picture.com>,
linux-kernel@vger.kernel.org
Subject: Re: 4096 byte limit to /proc/PID/environ ?
Date: Mon, 03 Sep 2007 10:17:11 +0200 [thread overview]
Message-ID: <h8fy1w40zc.fsf@pepelac.englab.brq.redhat.com> (raw)
In-Reply-To: <46D6CBED.4040301@moving-picture.com> (James Pearson's message of "Thu\, 30 Aug 2007 14\:53\:49 +0100")
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
James Pearson <james-p@moving-picture.com> writes:
> H. Peter Anvin wrote:
>> Guy Streeter wrote:
>>>On 6/1/06, James Pearson <james-p@moving-picture.com> wrote:
>>>>H. Peter Anvin wrote:
[...skipped...]
>>>>The following patch is based on the /proc/PID/mem code appears to work fine.
>>>This thread has gone stale. The PAGE_SIZE limit still exists. Is this
>>>solution acceptable?
>> Can we avoid the code duplication?
> There isn't that much that is duplicated - and there are also bits of
> the /proc/PID/mem code that are not needed in this case, so I'm not
> really sure if it is worth doing.
>
> I did submit a patch a few months ago - see:
> <http://marc.info/?l=linux-kernel&m=117862109623007&w=2>
Yep, I'm sure we should not reuse something from mem part, there are some insignificant code duplicating. If we will try to avoid this, it will complicate code and does not bring any advantage.
--
Anton Arapov, <aarapov@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2007-09-03 8:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 19:45 James Pearson
2006-05-24 20:29 ` H. Peter Anvin
[not found] ` <200605242029.k4OKTn9C031700@terminus.zytor.com>
2006-06-01 14:11 ` James Pearson
2007-08-15 16:54 ` Guy Streeter
2007-08-15 17:25 ` H. Peter Anvin
2007-08-21 14:40 ` Guy Streeter
2007-08-30 13:53 ` James Pearson
2007-09-03 8:17 ` Anton Arapov [this message]
2007-09-05 7:49 ` Anton Arapov
2007-09-05 7:58 ` H. Peter Anvin
2007-09-05 17:00 ` James Pearson
2007-09-05 17:18 ` Randy Dunlap
2007-09-06 9:23 ` James Pearson
2007-09-05 17:22 ` Alexey Dobriyan
2007-09-06 9:31 ` James Pearson
2007-09-06 12:31 ` Jan Engelhardt
2007-09-06 12:34 ` H. Peter Anvin
2007-09-06 12:34 ` Anton Arapov
-- strict thread matches above, loose matches on Subject: below --
2007-09-06 16:38 James Pearson
2007-09-18 14:09 ` Anton Arapov
2007-09-18 17:09 ` H. Peter Anvin
2006-05-24 15:54 James Pearson
2006-05-24 16:46 ` linux-os (Dick Johnson)
2006-05-24 16:59 ` James Pearson
2006-05-24 17:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h8fy1w40zc.fsf@pepelac.englab.brq.redhat.com \
--to=aarapov@redhat.com \
--cc=guy.streeter@gmail.com \
--cc=hpa@zytor.com \
--cc=james-p@moving-picture.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®