From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7415F334685 for ; Sat, 18 Apr 2026 19:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776541109; cv=none; b=DKqhn4bPALN2w3xL6Tf/32jXRq7QmaWqTJStSUaAzWZBRa5oGE+URAeSQmCUFWsuHPDO9KR8h+pmxnaDXdmtOiqW3zU/2DDeeRpT4g5aoxhWAXvvX3HuVe6B9q2xyKpEhl447zQbuGCXC6WjUsPGrKGbuQDVmNYmM1jsek7BWvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776541109; c=relaxed/simple; bh=D9bDtXxW3hYg3zOewGGHaPyX3bjoSoMDKPBs+JVD+jY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E8Pp5TTj9XFOK2mLUzRkZfIDrLrQYKA0uBZOqqxSP7yG3avgfHxCNwoUaiiaR9XK7o33Ra5NNAHRQhCwdM1iwVQ89GFHnGqFWjdXa9euzGdn0LiJKMtGm//Ldvd+FH/nzb0aYpPQPoyyK3YBbIDtN3k3i62HDgMAVL9MWqZUZIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iPZXIwGw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GvFRYeH2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iPZXIwGw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GvFRYeH2" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63I9QIix1106976 for ; Sat, 18 Apr 2026 19:38:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=kbwvqRx22EuSdW1o5avcOXEZ l4XvhLf+30K9TnHpX7o=; b=iPZXIwGw/DRx+Zt91iZVqqLZHLhQfaqwatR2rPg1 i8q/oA20HMpxH46pXKnyynNMPPH3db0oFL2PK63Bs7E27TI5ymG5qeIbZF5BvULk fRL+sK6vkRG52aO4231tZMZp6/iiQg6i5CfN59YvFzpx/VShtp1gXg1vrhaOqV+d sFE0aHqta25IQs3krIY5t1bY8CMV3neSQM9FM4XkgLm9RecZM35805nez8FbngXI oSi3ULWHzpk6HGHHBH/6wUwPVCfWam5B1MN7PYZg5E1pyeEM7b7ymoyHzfk2d+Mo pacK+MXqrVp5Yz+tWcCcwbV9AGMreEJX2ukMqJDehzcNAA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dm2b71b3v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Apr 2026 19:38:26 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d826ed6f9so67528581cf.1 for ; Sat, 18 Apr 2026 12:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776541105; x=1777145905; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kbwvqRx22EuSdW1o5avcOXEZl4XvhLf+30K9TnHpX7o=; b=GvFRYeH2nJbXQnVmTxae0cy5BJ8CC7+i6hHTuJzCbz2DZFQuqsp6h9lsSypaJ+R+cI jah43EYBSdWQPkMBJjUnHE3D3EJz4oShRVHehZgZmrdRI/vh6JqMfaY3/CAUzsagDUif odZGQ6ir9XhXkXSZX0iC6WBSmaCpVKaIiO2H59+3lW2cE/HmZl3WtLyBFpiok1/7vgHy l65wNvqR2nMICFVuR1Ly0GKJkTSrCUBtAW8nkQLStdyGAp/xHr45qG8f3S12jxNDg0W3 mknq8FT85rCigmT+2sj++Ytf0n7KH6U+JgqhVR8g0473fOUeLVokq9RNKiQ6jEpdvRYz M61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776541105; x=1777145905; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kbwvqRx22EuSdW1o5avcOXEZl4XvhLf+30K9TnHpX7o=; b=o0xdWk30nCHN2aC/MQ+yN/9cKJYyskK8ybl59dR7dJaAPLS2Ir22zVJqL/V98yUNMC J7DHwnsUffUjGklgsy80EglY9whqqjgzCSRjXyu/5lyk/0nJ4dMv5W1hksedWJDxw00p c80di/GoWh3PI9F08O0y0tIcvAz7Q5SL/XmRD23qgL01I57Ft60dgJu3awfme0DMaKVL zmxW4ME/c9h9jLAkx0AA5V6jqAuNN93QFGP/2+uhs84rjqAKP+oyTXRx9r8rixFfPNmC LWnPONw+6C4ID2FllVLR1gGyPk7jtr6B9l09xigouIRhl82ju296RZocgR2SALlCQTlC Cp5A== X-Forwarded-Encrypted: i=1; AFNElJ/0mQWzVme63nxn/s1Wj6wpkaQFfreE1k79KrXbvmWBuufLgSFgyHZO9kNWpIP50f2NwIsx5V+oHkWNLC8=@vger.kernel.org X-Gm-Message-State: AOJu0YxpRK1hypZAThnaiaLtt41xnIw/yfZQzaip32l3Bnxuj5ZmZUX6 DYBf5tX+/5/iarGQfe5zPpWWcCv9kWo5LkHmP4f4sSlHh6zW+/2Z9tN4T7y3+IbvN0z5zxcr28I V6fXDfH6jtJHGOJP9muAxoAfA6H8Hn219xX1jstnrw//bltsV9N3s0PpRTfNBWYzu5Pc= X-Gm-Gg: AeBDiet1fDVJb2sv4vxdZpZSauFdZNjUhkffN3j4PiWsq58fjYKwA/+2/3eRt4P68bQ PYhgLwkiTov1pCDDCS3zrEQBSuRGHFNqlEmnvEV+f+xHY7Zm7o5t3h4unmIs7qhkOxW8HgSAjWk gGAN3WPK7MJ2rAk/zzTD+dY+xL36DavgKBAOXviINBB2FK7XycjHx2Og5+UysvNbJdiLBIBM2wh othsH9P4awV/b8B889USUjpC/NqZMSsikmEAk5Bns8k4UTE1Ar930RnqCSFGHC9uG4HqZQ+y2vR 5nEwv5X+Na09ZBaSrJkwSNEMx06LkgEwF6EXfQT9ssWVhWDTv3U+RJRt7UIy6X7Y97qFkpcIA+z yK4lqO6DV7Rdu2nICDF8rd4/o8KfLdyMPotZ2nI26rUfN8gee8ghUN9elAa3Oj1gD68vl4Bmrty QZIwvsoDjmUWbSf07UmKTjz7C8o0Wf88of6KiRW4RT7fSQNA== X-Received: by 2002:a05:622a:48c:b0:50d:9c1b:941f with SMTP id d75a77b69052e-50e3661b147mr97389901cf.8.1776541105490; Sat, 18 Apr 2026 12:38:25 -0700 (PDT) X-Received: by 2002:a05:622a:48c:b0:50d:9c1b:941f with SMTP id d75a77b69052e-50e3661b147mr97389461cf.8.1776541105035; Sat, 18 Apr 2026 12:38:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4187e7dd0sm1553387e87.69.2026.04.18.12.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 12:38:22 -0700 (PDT) Date: Sat, 18 Apr 2026 22:38:21 +0300 From: Dmitry Baryshkov To: Luca Weiss Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Vinod Koul , Balakrishna Godavarthi , Matthias Kaehlcke , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-pm@vger.kernel.org, Krzysztof Kozlowski , Bartosz Golaszewski Subject: Re: [PATCH v3 3/8] wifi: ath10k: snoc: support powering on the device via pwrseq Message-ID: References: <20260119-wcn3990-pwrctl-v3-0-948df19f5ec2@oss.qualcomm.com> <20260119-wcn3990-pwrctl-v3-3-948df19f5ec2@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=KZridwYD c=1 sm=1 tr=0 ts=69e3ddb2 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=Rs7pINfTDodmtXVth3IA:9 a=CjuIK1q_8ugA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE4MDE5NiBTYWx0ZWRfXxzcgOn0vWBdz vLolfHiSCzzDFYawoelcw5Y+Ak/SaVop9eMMCwWil6gP3pGsFpJ27NN4xA/TrNmRkUrjV7y+c5B 1ug/C3d/xh/wtjv9gfHajfAwAVPkbF3mVrbTYEBvW/ypm2NEjPbZyBQn1H4IwYR8GPu0Hljq9tE l6L/YoP3UN5xM6ac7j5Mb1hdEZO7Q7UJzbUNJwxWekr0XLpexRF2jO+95OOfNrE0guCIZQJTsKv H0XS2g92Qr/Um/Ap83tblH8ait92jCBkC1vsajKShJLcOMLwjB/IPEvmJznu89PWLCymO0RySx9 8Z0qnajbdn4n/GnH6FnqgXw6LPg7/254z+n0LhN/2fS1wQfiyCgUIk03BCylAmLaAF/ab/prJ3d HfNbQZKSeFcWSbWISQgGtcV5vMhrfaoo1RNQEllspXqCl+pPdXTqCXstQyAyQXAHDD5Azrwa4mL n72Dtn5flJu6ir/wOwg== X-Proofpoint-GUID: 1XBdfa9PMy_0JxSYGXl8Hk5wbNBPH9My X-Proofpoint-ORIG-GUID: 1XBdfa9PMy_0JxSYGXl8Hk5wbNBPH9My X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-18_05,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604180196 On Thu, Apr 16, 2026 at 12:06:09PM +0200, Luca Weiss wrote: > Hi Dmitry, > > On Mon Jan 19, 2026 at 6:07 PM CET, Dmitry Baryshkov wrote: > > The WCN39xx family of WiFi/BT chips incorporates a simple PMU, spreading > > voltages over internal rails. Implement support for using powersequencer > > for this family of ATH10k devices in addition to using regulators. > > > > Reviewed-by: Bartosz Golaszewski > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/net/wireless/ath/ath10k/snoc.c | 53 ++++++++++++++++++++++++++++++++-- > > drivers/net/wireless/ath/ath10k/snoc.h | 3 ++ > > 2 files changed, 53 insertions(+), 3 deletions(-) > > > > + ar_snoc->pwrseq = devm_pwrseq_get(&pdev->dev, "wlan"); > > + if (IS_ERR(ar_snoc->pwrseq)) { > > + ret = PTR_ERR(ar_snoc->pwrseq); > > + ar_snoc->pwrseq = NULL; > > + if (ret != -EPROBE_DEFER) > > + goto err_free_irq; > > I'm fairly sure this is now broken with CONFIG_POWER_SEQUENCING=n since > then pwrseq_get() is returning ERR_PTR(-ENOSYS) which is not handled > here. > > I'm observing my ath10k_snoc is now failing to probe "with error -38" > which definitely seems to be related, but I haven't debugged it further > yet. Posted https://patch.msgid.link/20260418-ath10k-snoc-pwrseq-v1-1-832594ba3294@oss.qualcomm.com -- With best wishes Dmitry