mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Hu <weh@linux.microsoft.com>
To: netdev-bot+sashiko@kernel.org
Cc: longli@kernel.org, kotaranov@microsoft.com, kuba@kernel.org,
	davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	andrew+netdev@lunn.ch, jgg@ziepe.ca, leon@kernel.org,
	haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
	shradhagupta@linux.microsoft.com, horms@kernel.org,
	ernis@linux.microsoft.com, stephen@networkplumber.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	gargaditya@linux.microsoft.com, kees+treewide@kernel.org,
	kees@kernel.org, mawasthi@linux.microsoft.com, weh@microsoft.com,
	edumazet@kernel.org
Subject: Re: [PATCH net-next v8 2/4] net: mana: give each HWC message slot its own completion state
Date: Thu, 22 Oct 2026 14:44:08 +0000	[thread overview]
Message-ID: <hwc-v9-v8-review-20261022-patch2-b09e6c742e9b326f8dde@linux.microsoft.com> (raw)
In-Reply-To: <179250339038.3135.16651240191139289948@kernel.org>

Thanks for the review.

On Tue, 20 Oct 2026 13:36:30 +0000, netdev-bot+sashiko@kernel.org wrote:

> This isn't a bug introduced by this patch, but can this memcpy() read
> past the end of the RX slot?

This is pre-existing in the baseline driver; we will address separately.
As noted in the review, patch 4 already bounds the requested response
size by the RX slot capacity before admission in the completed series.

> This isn't a bug introduced by this patch, but can a late response for a
> timed-out command be delivered to the next sender that reuses this
> msg_id?

This is pre-existing in the baseline driver; we will address separately.
As noted in the review, patch 3 already keeps a timed-out slot reserved
until its pending response is consumed or teardown retires it. That
protection remains in v9.

Regards,
Wei

  reply	other threads:[~2026-10-22 14:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 12:06 [PATCH net-next v8 0/4] net: mana: concurrent HWC requests and dynamic queue depth Wei Hu
2026-10-16 12:06 ` [PATCH net-next v8 1/4] net: mana: prepare HWC ownership for safe reinitialization Wei Hu
2026-10-20 13:36   ` netdev-bot+sashiko
2026-10-22 14:44     ` Wei Hu
2026-10-16 12:06 ` [PATCH net-next v8 2/4] net: mana: give each HWC message slot its own completion state Wei Hu
2026-10-20 13:36   ` netdev-bot+sashiko
2026-10-22 14:44     ` Wei Hu [this message]
2026-10-16 12:06 ` [PATCH net-next v8 3/4] net: mana: support concurrent HWC requests Wei Hu
2026-10-20 13:36   ` netdev-bot+sashiko
2026-10-22 14:44     ` Wei Hu
2026-10-16 12:06 ` [PATCH net-next v8 4/4] net: mana: add dynamic HWC queue depth with reinit path Wei Hu
2026-10-20 13:36   ` netdev-bot+sashiko
2026-10-22 14:44     ` Wei Hu
2026-10-21 20:40 ` [PATCH net-next v8 0/4] net: mana: concurrent HWC requests and dynamic queue depth Jakub Kicinski
2026-10-22 14:54   ` [EXTERNAL] " Wei Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hwc-v9-v8-review-20261022-patch2-b09e6c742e9b326f8dde@linux.microsoft.com \
    --to=weh@linux.microsoft.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=edumazet@google.com \
    --cc=edumazet@kernel.org \
    --cc=ernis@linux.microsoft.com \
    --cc=gargaditya@linux.microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=horms@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kees+treewide@kernel.org \
    --cc=kees@kernel.org \
    --cc=kotaranov@microsoft.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@kernel.org \
    --cc=mawasthi@linux.microsoft.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shradhagupta@linux.microsoft.com \
    --cc=stephen@networkplumber.org \
    --cc=weh@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®