From: Oliver Neukum <Oliver.Neukum@lrz.uni-muenchen.de>
To: Gerd Knorr <kraxel@bytesex.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.5 videodev redesign -- #3
Date: Mon, 4 Mar 2002 14:54:32 +0100 [thread overview]
Message-ID: <iss.60a3.3c83c0b2.401f5.2@mailout.lrz-muenchen.de> (raw)
In-Reply-To: <20020302151538.A7839@bytesex.org> <iss.28ea.3c83389c.370f5.1@mailout.lrz-muenchen.de> <slrna86gll.lh9.kraxel@bytesex.org>
In-Reply-To: <slrna86gll.lh9.kraxel@bytesex.org>
Am Montag, 4. März 2002 10:47 schrieb Gerd Knorr:
> > > Comments? Bugs? I plan to feed this to Linus soon ...
> >
> > Hi,
> >
> > it seems to me that you are not holding the BKL during
> > the open method of the individual driver. This will
> > cause races with unplugging on some USB cameras.
>
> What race exactly?
open() can race with videodev_unregister()
> I don't want videodev.c know details about the devices, it doesn't
> belong there. If a usb cam needs locking, the usb cam's open() function
> should do that then. I'll prefare fixing the usb drivers instead of
> calling driver->open() with BKL held.
Problematic. I found no other solution than the BKL.
Regards
Oliver
prev parent reply other threads:[~2002-03-04 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-02 14:15 Gerd Knorr
2002-03-04 8:17 ` Oliver Neukum
2002-03-04 9:47 ` Gerd Knorr
2002-03-04 12:50 ` Gerd Knorr
2002-03-04 18:45 ` Oliver Neukum
2002-03-04 13:54 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iss.60a3.3c83c0b2.401f5.2@mailout.lrz-muenchen.de \
--to=oliver.neukum@lrz.uni-muenchen.de \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®