From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Petr Tesarik <petrtesarik@huaweicloud.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"open list:SUPERH" <linux-sh@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Roberto Sassu <roberto.sassu@huaweicloud.com>,
petr@tesarici.cz
Subject: Re: [PATCH v1] sh: boards: fix CEU buffer size passed to dma_declare_coherent_memory()
Date: Mon, 24 Jul 2023 15:22:50 +0200 [thread overview]
Message-ID: <jang73ontcdxo7zliixfeyll7za5e7es2rfjc53kpube7bq5nv@fhbxuk37o7kb> (raw)
In-Reply-To: <20230724120742.2187-1-petrtesarik@huaweicloud.com>
Hi Petr,
On Mon, Jul 24, 2023 at 02:07:42PM +0200, Petr Tesarik wrote:
> From: Petr Tesarik <petr.tesarik.ext@huawei.com>
>
> In all these cases, the last argument to dma_declare_coherent_memory() is
> the buffer end address, but the expected value should be the size of the
> reserved region.
>
> Fixes: 39fb993038e1 ("media: arch: sh: ap325rxa: Use new renesas-ceu camera driver")
> Fixes: c2f9b05fd5c1 ("media: arch: sh: ecovec: Use new renesas-ceu camera driver")
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
> Fixes: 186c446f4b84 ("media: arch: sh: migor: Use new renesas-ceu camera driver")
> Fixes: 1a3c230b4151 ("media: arch: sh: ms7724se: Use new renesas-ceu camera driver")
Ups, seems like I have introduced all of these! thanks for fixing
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Thanks
j
> Signed-off-by: Petr Tesarik <petr.tesarik.ext@huawei.com>
> ---
> arch/sh/boards/mach-ap325rxa/setup.c | 2 +-
> arch/sh/boards/mach-ecovec24/setup.c | 6 ++----
> arch/sh/boards/mach-kfr2r09/setup.c | 2 +-
> arch/sh/boards/mach-migor/setup.c | 2 +-
> arch/sh/boards/mach-se/7724/setup.c | 6 ++----
> 5 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/arch/sh/boards/mach-ap325rxa/setup.c b/arch/sh/boards/mach-ap325rxa/setup.c
> index 151792162152..645cccf3da88 100644
> --- a/arch/sh/boards/mach-ap325rxa/setup.c
> +++ b/arch/sh/boards/mach-ap325rxa/setup.c
> @@ -531,7 +531,7 @@ static int __init ap325rxa_devices_setup(void)
> device_initialize(&ap325rxa_ceu_device.dev);
> dma_declare_coherent_memory(&ap325rxa_ceu_device.dev,
> ceu_dma_membase, ceu_dma_membase,
> - ceu_dma_membase + CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
>
> platform_device_add(&ap325rxa_ceu_device);
>
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 674da7ebd8b7..7ec03d4a4edf 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -1454,15 +1454,13 @@ static int __init arch_setup(void)
> device_initialize(&ecovec_ceu_devices[0]->dev);
> dma_declare_coherent_memory(&ecovec_ceu_devices[0]->dev,
> ceu0_dma_membase, ceu0_dma_membase,
> - ceu0_dma_membase +
> - CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
> platform_device_add(ecovec_ceu_devices[0]);
>
> device_initialize(&ecovec_ceu_devices[1]->dev);
> dma_declare_coherent_memory(&ecovec_ceu_devices[1]->dev,
> ceu1_dma_membase, ceu1_dma_membase,
> - ceu1_dma_membase +
> - CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
> platform_device_add(ecovec_ceu_devices[1]);
>
> gpiod_add_lookup_table(&cn12_power_gpiod_table);
> diff --git a/arch/sh/boards/mach-kfr2r09/setup.c b/arch/sh/boards/mach-kfr2r09/setup.c
> index 20f4db778ed6..c6d556dfbbbe 100644
> --- a/arch/sh/boards/mach-kfr2r09/setup.c
> +++ b/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -603,7 +603,7 @@ static int __init kfr2r09_devices_setup(void)
> device_initialize(&kfr2r09_ceu_device.dev);
> dma_declare_coherent_memory(&kfr2r09_ceu_device.dev,
> ceu_dma_membase, ceu_dma_membase,
> - ceu_dma_membase + CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
>
> platform_device_add(&kfr2r09_ceu_device);
>
> diff --git a/arch/sh/boards/mach-migor/setup.c b/arch/sh/boards/mach-migor/setup.c
> index f60061283c48..773ee767d0c4 100644
> --- a/arch/sh/boards/mach-migor/setup.c
> +++ b/arch/sh/boards/mach-migor/setup.c
> @@ -604,7 +604,7 @@ static int __init migor_devices_setup(void)
> device_initialize(&migor_ceu_device.dev);
> dma_declare_coherent_memory(&migor_ceu_device.dev,
> ceu_dma_membase, ceu_dma_membase,
> - ceu_dma_membase + CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
>
> platform_device_add(&migor_ceu_device);
>
> diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
> index b60a2626e18b..6495f9354065 100644
> --- a/arch/sh/boards/mach-se/7724/setup.c
> +++ b/arch/sh/boards/mach-se/7724/setup.c
> @@ -940,15 +940,13 @@ static int __init devices_setup(void)
> device_initialize(&ms7724se_ceu_devices[0]->dev);
> dma_declare_coherent_memory(&ms7724se_ceu_devices[0]->dev,
> ceu0_dma_membase, ceu0_dma_membase,
> - ceu0_dma_membase +
> - CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
> platform_device_add(ms7724se_ceu_devices[0]);
>
> device_initialize(&ms7724se_ceu_devices[1]->dev);
> dma_declare_coherent_memory(&ms7724se_ceu_devices[1]->dev,
> ceu1_dma_membase, ceu1_dma_membase,
> - ceu1_dma_membase +
> - CEU_BUFFER_MEMORY_SIZE - 1);
> + CEU_BUFFER_MEMORY_SIZE);
> platform_device_add(ms7724se_ceu_devices[1]);
>
> return platform_add_devices(ms7724se_devices,
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-07-24 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 12:07 Petr Tesarik
2023-07-24 13:01 ` Geert Uytterhoeven
2023-07-24 13:22 ` Jacopo Mondi [this message]
2023-07-24 15:34 ` Petr Tesařík
2023-07-24 17:12 ` Laurent Pinchart
2023-07-24 17:29 ` John Paul Adrian Glaubitz
2023-07-24 17:43 ` Laurent Pinchart
2023-07-25 5:45 ` Petr Tesařík
2023-07-25 5:50 ` John Paul Adrian Glaubitz
2023-07-25 11:09 ` Laurent Pinchart
2023-07-25 11:38 ` John Paul Adrian Glaubitz
2023-07-25 12:42 ` Laurent Pinchart
2023-07-25 12:21 ` D. Jeff Dionne
2023-09-08 9:36 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jang73ontcdxo7zliixfeyll7za5e7es2rfjc53kpube7bq5nv@fhbxuk37o7kb \
--to=jacopo.mondi@ideasonboard.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=petr@tesarici.cz \
--cc=petrtesarik@huaweicloud.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®