Re: atomic64_t proposal

[Andreas Schwab <schwab@suse.de>]

Dean Nelson <dcn@sgi.com> writes:

|> +#define ia64_atomic_add(i,v)						\
|> +({									\
|> +	__typeof__((v)->counter) _old, _new;				\
|> +	CMPXCHG_BUGCHECK_DECL						\
|> +									\
|> +	do {								\
|> +		CMPXCHG_BUGCHECK(v);					\
|> +		_old = atomic_read(v);					\
|> +		_new = _old + (i);					\
|> +	} while (ia64_cmpxchg("acq", (v), _old, _new, sizeof(*(v))) != _old); \
|> +	(__typeof__((v)->counter)) _new;	/* return new value */	\

What's the purpose of the cast here? The type of _new is already the
right one.

|>  #define atomic_add_return(i,v)						\
|>  	((__builtin_constant_p(i) &&					\
|>  	  (   (i ==  1) || (i ==  4) || (i ==  8) || (i ==  16)		\
|>  	   || (i == -1) || (i == -4) || (i == -8) || (i == -16)))	\
|>  	 ? ia64_fetch_and_add(i, &(v)->counter)				\
|> -	 : ia64_atomic_add(i, v))
|> +	 : ia64_atomic_add((i), (v)))

The extra parens are useless.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."