From: Andreas Schwab <schwab@suse.de>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org,
zippel@linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()
Date: Thu, 21 Feb 2008 17:38:52 +0100 [thread overview]
Message-ID: <je4pc2s1r7.fsf@sykes.suse.de> (raw)
In-Reply-To: <20080221155402.4414.60360.stgit@warthog.procyon.org.uk> (David Howells's message of "Thu\, 21 Feb 2008 15\:54\:02 +0000")
David Howells <dhowells@redhat.com> writes:
> if (time_offset < 0) {
> - temp64 = -temp64;
> - do_div(temp64, mtemp);
> + utemp64 = -temp64;
> + do_div(utemp64, mtemp);
> freq_adj -= temp64;
do_div previously modified temp64 by side effect, now it no longer does
that.
> } else {
> - do_div(temp64, mtemp);
> + utemp64 = temp64;
> + do_div(utemp64, mtemp);
> freq_adj += temp64;
Same.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-02-21 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 15:54 David Howells
2008-02-21 16:38 ` Andreas Schwab [this message]
2008-02-21 16:46 ` David Howells
2008-02-26 1:55 ` Roman Zippel
2008-02-26 2:01 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4pc2s1r7.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®