From: Andreas Schwab <schwab@suse.de>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH][2.6] Completely out of line spinlocks / i386
Date: Sun, 08 Aug 2004 14:33:07 +0200 [thread overview]
Message-ID: <je4qndlsho.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0408080143230.19619@montezuma.fsmlabs.com> (Zwane Mwaikambo's message of "Sun, 8 Aug 2004 02:00:32 -0400 (EDT)")
Zwane Mwaikambo <zwane@linuxpower.ca> writes:
> Index: linux-2.6.8-rc3-mm1/arch/i386/lib/spinlock.c
> ===================================================================
> RCS file: linux-2.6.8-rc3-mm1/arch/i386/lib/spinlock.c
> diff -N linux-2.6.8-rc3-mm1/arch/i386/lib/spinlock.c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ linux-2.6.8-rc3-mm1/arch/i386/lib/spinlock.c 8 Aug 2004 05:39:13 -0000
Why not just make this an assembler source? It contains no real C code.
The only downside is that EXPORT_SYMBOL must be moved elsewhere, but on
the other hand it would make the assembler code more readable,
> +#define PROC(name) \
> + ".align 4\n" \
> + ".globl " #name"\n" \
> + #name":\n"
and you could use ENTRY from <linux/linkage.h>.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-08-08 12:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 4:49 Zwane Mwaikambo
2004-08-08 5:01 ` Linus Torvalds
2004-08-08 5:17 ` Zwane Mwaikambo
2004-08-08 5:21 ` Linus Torvalds
2004-08-08 6:00 ` Zwane Mwaikambo
2004-08-08 12:33 ` Andreas Schwab [this message]
2004-08-08 18:26 ` Zwane Mwaikambo
2004-08-11 21:59 ` Pavel Machek
2004-08-11 22:13 ` Linus Torvalds
2004-08-11 22:23 ` William Lee Irwin III
2004-08-12 0:01 ` Keith Owens
2004-08-12 0:39 ` David S. Miller
2004-08-12 0:54 ` Zwane Mwaikambo
2004-08-12 1:01 ` William Lee Irwin III
2004-08-12 1:37 ` Zwane Mwaikambo
2004-08-12 2:04 ` William Lee Irwin III
2004-08-12 7:20 ` William Lee Irwin III
2004-08-12 7:23 ` William Lee Irwin III
2004-08-12 7:25 ` William Lee Irwin III
2004-08-12 8:12 ` Zwane Mwaikambo
2004-08-12 8:11 ` William Lee Irwin III
2004-08-12 8:54 ` William Lee Irwin III
2004-08-13 8:01 ` William Lee Irwin III
2004-08-13 9:16 ` William Lee Irwin III
2004-08-13 9:30 ` William Lee Irwin III
2004-08-13 9:46 ` William Lee Irwin III
2004-08-13 10:05 ` William Lee Irwin III
2004-08-13 10:23 ` William Lee Irwin III
2004-08-13 10:39 ` William Lee Irwin III
2004-08-13 14:15 ` Zwane Mwaikambo
2004-08-13 14:29 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4qndlsho.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=torvalds@osdl.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®