From: Andreas Schwab <schwab@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radeonfb: (#2) Implement proper workarounds for PLL accesses
Date: Tue, 05 Apr 2005 23:44:35 +0200 [thread overview]
Message-ID: <je8y3wyk3g.fsf@sykes.suse.de> (raw)
In-Reply-To: <1110672745.5787.60.camel@gaston> (Benjamin Herrenschmidt's message of "Sun, 13 Mar 2005 11:12:25 +1100")
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> After discussion with ATIs, it seems that the workarounds they initially
> gave me were not completely correct.
>
> This patch implements the proper ones, which includes sleeping in PLL
> accesses, and thus requires the previous patch to make sure we do not
> call unblank at interrupt time (unless oops_in_progress is set, in which
> case I use an mdelay).
>
> It also removes obsolete code that used to disable some power management
> features in the accel init code.
This patch does no good on Radeon M6 (iBook G3). It makes mode switching
to take an extraordinary amount of time, ie. when switching away from X it
takes about 2-3 seconds until the console is restored.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-04-05 21:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 5:42 [PATCH] radeonfb: " Benjamin Herrenschmidt
2005-03-13 0:12 ` [PATCH] radeonfb: (#2) " Benjamin Herrenschmidt
2005-04-05 21:44 ` Andreas Schwab [this message]
2005-04-05 23:31 ` Benjamin Herrenschmidt
2005-04-06 22:35 ` Andreas Schwab
2005-04-06 22:47 ` Benjamin Herrenschmidt
2005-04-07 20:21 ` Andreas Schwab
2005-04-07 21:22 ` Dave Airlie
2005-04-07 22:59 ` Benjamin Herrenschmidt
2005-04-07 23:58 ` Andreas Schwab
2005-04-08 0:03 ` Benjamin Herrenschmidt
2005-04-08 1:19 ` Benjamin Herrenschmidt
2005-04-08 21:11 ` Andreas Schwab
2005-04-09 0:03 ` Benjamin Herrenschmidt
2005-04-09 16:24 ` Andreas Schwab
2005-04-09 23:33 ` Benjamin Herrenschmidt
2005-04-10 10:05 ` Moritz Muehlenhoff
2005-04-10 22:45 ` Benjamin Herrenschmidt
2005-04-10 23:10 ` Brice Goglin
2005-04-07 22:47 ` Benjamin Herrenschmidt
2005-04-07 23:13 ` Andreas Schwab
2005-04-07 23:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je8y3wyk3g.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®