Re: div64.h:do_div() bug

[Andreas Schwab <schwab@suse.de>]

Matti Aarnio <matti.aarnio@zmailer.org> writes:

> On Tue, Sep 30, 2003 at 01:14:38PM +0300, Matti Aarnio wrote:
>> On Tue, Sep 30, 2003 at 11:52:29AM +0200, Rogier Wolff wrote:
>> > On Mon, Sep 29, 2003 at 03:25:19PM +0200, Artur Klauser wrote:
>> > > I've found that a bug in asm-arm/div64.h:do_div() is preventing correct
>> > > conversion of timestamps in smbfs (and probably ntfs as well) from NT to
>> > 
>> > Nope. 
>> 
>>   Nope yourself.
>> 
>> > >   if (in.n64 != out.n64) {
>> > >     printf("FAILURE: asm/div64.h:do_div() is broken for 64-bit dividends\n");
>> > 
>> > do_div should be/is documented as not doing 64 bit dividents. It does
>> > 64/32 -> 32 divides, IIRC... 
>> 
>>   64/32 -> 64,32
>> 
>> The REMAINDER is 32 bit value.
>
> Non-native english speaker makes the mistake..  MODULUS is 32 bits as is
> DIVISOR, REMAINDER is 64 bit, as is DIVIDEND.
>
> That is:
> 	DIVIDEND / DIVISOR -> REMAINDER , MODULUS
                              ^^^^^^^^^^^^^^^^^^^
???
                              QUOTIENT, REMAINDER

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."