From: Andreas Schwab <schwab@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
"Sergey S. Kostyliov" <rathamahata@php4.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] befs: use strlcpy()
Date: Sun, 30 Oct 2005 11:38:36 +0100 [thread overview]
Message-ID: <jebr175lxv.fsf@sykes.suse.de> (raw)
In-Reply-To: <20051030011817.GA32602@mipter.zuzino.mipt.ru> (Alexey Dobriyan's message of "Sun, 30 Oct 2005 04:18:17 +0300")
Alexey Dobriyan <adobriyan@gmail.com> writes:
> --- a/fs/befs/btree.c
> +++ b/fs/befs/btree.c
> @@ -503,10 +503,9 @@ befs_btree_read(struct super_block *sb,
> goto error_alloc;
> };
>
> - strncpy(keybuf, keystart, keylen);
> + strlcpy(keybuf, keystart, keylen);
> *value = fs64_to_cpu(sb, valarray[cur_key]);
> *keysize = keylen;
> - keybuf[keylen] = '\0';
You are now cutting off the last character of the string. keylen is the
exact size of the string to be copied, _not_ the size of the buffer (which
is bufsize and guaranteed to be big enough at this point).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2005-10-30 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 1:18 Alexey Dobriyan
2005-10-30 10:38 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jebr175lxv.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rathamahata@php4.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®