From: Andreas Schwab <schwab@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
linux-kernel@vger.kernel.org,
LIOU Payphone <lioupayphone@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Forbid user to change file flags on quota files
Date: Mon, 05 Nov 2007 11:47:01 +0100 [thread overview]
Message-ID: <jefxzlas0q.fsf@sykes.suse.de> (raw)
In-Reply-To: <20071105103230.GA9561@duck.suse.cz> (Jan Kara's message of "Mon\, 5 Nov 2007 11\:32\:30 +0100")
Jan Kara <jack@suse.cz> writes:
> On Fri 02-11-07 18:32:08, Jan Engelhardt wrote:
>>
>> On Nov 1 2007 16:52, Jan Kara wrote:
>>
>> >--- linux-2.6.24-rc1/fs/ext2/ioctl.c 2007-10-24 20:43:56.000000000 +0200
>> >+++ linux-2.6.24-rc1-1-forbid_setflags/fs/ext2/ioctl.c 2007-11-01 16:01:26.000000000 +0100
>> >@@ -47,6 +47,11 @@ int ext2_ioctl (struct inode * inode, st
>> > flags &= ~EXT2_DIRSYNC_FL;
>> >
>> > mutex_lock(&inode->i_mutex);
>> >+ /* Is it quota file? Don't allow user mess with it */
>>
>> "Do not allow user to mess with it".
> I think both "allow user mess" and "allow user to mess" are possible,
I think it's either "to allow doing sth" or "to allow to do sth", but
"to allow do sth" looks definitely wrong to me.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2007-11-05 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 15:52 Jan Kara
2007-11-02 17:32 ` Jan Engelhardt
2007-11-05 10:32 ` Jan Kara
2007-11-05 10:47 ` Andreas Schwab [this message]
2007-11-05 16:58 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jefxzlas0q.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lioupayphone@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®