From: Andreas Schwab <schwab@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Consistently translate LF to CRLF on serial console
Date: Fri, 19 Mar 2004 10:18:03 +0100 [thread overview]
Message-ID: <jek71hb3g4.fsf@sykes.suse.de> (raw)
In-Reply-To: <1079661779.1947.81.camel@gaston> (Benjamin Herrenschmidt's message of "Fri, 19 Mar 2004 13:03:00 +1100")
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Fri, 2004-03-19 at 10:30, Andreas Schwab wrote:
>> Some serial console drivers translate LF to CRLF, some do LFCR. This
>> patch changes them to consistently translate to CRLF.
>
> macserial is obsolete (and will be soon removed), please look
> into pmac zilog rather.
I did.
> Also, why did you move the test for
> the transmit buffer empty ? You should at least check there
> is room in it _before_ writing to it
I did that too.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2004-03-19 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 23:30 Andreas Schwab
2004-03-19 2:03 ` Benjamin Herrenschmidt
2004-03-19 9:18 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jek71hb3g4.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®