From: Andreas Schwab <schwab@suse.de>
To: Michael Buesch <freesoftwaredeveloper@web.de>
Cc: linux-kernel@vger.kernel.org, "Paweł Gołaszewski" <blues@ds.pg.gda.pl>
Subject: Re: [2.5.67] gen_rtc compile error
Date: Tue, 08 Apr 2003 21:40:43 +0200 [thread overview]
Message-ID: <jek7e4ixqc.fsf@sykes.suse.de> (raw)
In-Reply-To: <200304082130.07080.freesoftwaredeveloper@web.de> (Michael Buesch's message of "Tue, 8 Apr 2003 21:30:07 +0200")
Michael Buesch <freesoftwaredeveloper@web.de> writes:
|> Correcting my patch: ;)
Still not right.
|> --- drivers/char/genrtc.c.orig 2003-04-08 21:15:52.000000000 +0200
|> +++ drivers/char/genrtc.c 2003-04-08 21:28:43.000000000 +0200
|> @@ -486,16 +486,21 @@
|> "update_IRQ\t: %s\n"
|> "periodic_IRQ\t: %s\n"
|> "periodic_freq\t: %ld\n"
|> - "batt_status\t: %s\n",
|> - (flags & RTC_DST_EN) ? "yes" : "no",
|> +#ifdef RTC_BATT_BAD
|> + "batt_status\t: %s\n"
|> +#endif
|> + ,(flags & RTC_DST_EN) ? "yes" : "no",
|> (flags & RTC_DM_BINARY) ? "no" : "yes",
|> (flags & RTC_24H) ? "yes" : "no",
|> (flags & RTC_SQWE) ? "yes" : "no",
|> (flags & RTC_AIE) ? "yes" : "no",
|> irq_active ? "yes" : "no",
|> (flags & RTC_PIE) ? "yes" : "no",
|> - 0L /* freq */,
|> - (flags & RTC_BATT_BAD) ? "bad" : "okay");
|> + 0L /* freq */
|> +#ifdef RTC_BATT_BAD
|> + ,(flags & RTC_BATT_BAD) ? "bad" : "okay")
|> +#endif
|> + ;
Lacks a close paren if !RTC_BATT_BAD.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2003-04-08 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-08 18:37 Paweł Gołaszewski
2003-04-08 19:20 ` Michael Buesch
2003-04-08 19:28 ` Paweł Gołaszewski
2003-04-08 19:30 ` Michael Buesch
2003-04-08 19:40 ` Andreas Schwab [this message]
2003-04-08 19:46 ` Michael Buesch
2003-04-08 19:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jek7e4ixqc.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=blues@ds.pg.gda.pl \
--cc=freesoftwaredeveloper@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®