From: Andreas Schwab <schwab@suse.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, hjk@linutronix.de, gregkh@suse.de
Subject: Re: [PATCH] [UIO] Add alignment warnings for uio-mem
Date: Thu, 18 Sep 2008 17:03:19 +0200 [thread overview]
Message-ID: <jeljxpfqdk.fsf@sykes.suse.de> (raw)
In-Reply-To: <20080918144615.GD4226@pengutronix.de> (Wolfram Sang's message of "Thu, 18 Sep 2008 16:46:15 +0200")
Wolfram Sang <w.sang@pengutronix.de> writes:
> + dev_warn(idev->dev, "mem[%d] not page aligned!"
> + "Fixing values.\n", mem - info->mem);
Minor nit: please add a space to the message.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2008-09-18 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 14:46 Wolfram Sang
2008-09-18 15:03 ` Andreas Schwab [this message]
2008-09-18 21:53 ` Hans J. Koch
2008-09-19 8:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeljxpfqdk.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome