From: Andreas Schwab <schwab@suse.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hlist_for_each_safe cleanup
Date: Fri, 23 Jul 2004 23:22:23 +0200 [thread overview]
Message-ID: <jeoem65shc.fsf@sykes.suse.de> (raw)
In-Reply-To: <20040723140527.7e3c119a@dell_ss3.pdx.osdl.net> (Stephen Hemminger's message of "Fri, 23 Jul 2004 14:05:27 -0700")
Stephen Hemminger <shemminger@osdl.org> writes:
> --- linux-2.6/include/linux/list.h 2004-07-23 09:36:18.000000000 -0700
> +++ tcp-2.6/include/linux/list.h 2004-07-23 11:43:25.000000000 -0700
> @@ -620,13 +620,12 @@
>
> #define hlist_entry(ptr, type, member) container_of(ptr,type,member)
>
> -/* Cannot easily do prefetch unfortunately */
> #define hlist_for_each(pos, head) \
> for (pos = (head)->first; pos && ({ prefetch(pos->next); 1; }); \
> pos = pos->next)
>
> #define hlist_for_each_safe(pos, n, head) \
> - for (pos = (head)->first; n = pos ? pos->next : NULL, pos; \
> + for (pos = (head)->first; pos && ({ n = pos->next; 1; }); \
What's wrong with using the comma operator instead of non-standard
statement expressions?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2004-07-23 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 21:05 Stephen Hemminger
2004-07-23 21:22 ` Andreas Schwab [this message]
2004-07-23 22:56 ` Stephen Hemminger
2004-07-23 23:13 ` Andreas Schwab
2004-07-25 9:32 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeoem65shc.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®