From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65255C433E0 for ; Thu, 4 Jun 2020 10:56:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E8762075B for ; Thu, 4 Jun 2020 10:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgFDK4L (ORCPT ); Thu, 4 Jun 2020 06:56:11 -0400 Received: from foss.arm.com ([217.140.110.172]:43154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgFDK4L (ORCPT ); Thu, 4 Jun 2020 06:56:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 333BE55D; Thu, 4 Jun 2020 03:56:10 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E1AE3F6CF; Thu, 4 Jun 2020 03:56:09 -0700 (PDT) References: <20200603173150.GB1551@shell.armlinux.org.uk> <20200603184500.GC1551@shell.armlinux.org.uk> <20200603195853.GD1551@shell.armlinux.org.uk> <20200604092901.GE1551@shell.armlinux.org.uk> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Russell King - ARM Linux admin Cc: Thara Gopinath , Vincent Guittot , linux-kernel Subject: Re: v5.7: new core kernel option missing help text In-reply-to: <20200604092901.GE1551@shell.armlinux.org.uk> Date: Thu, 04 Jun 2020 11:56:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/20 10:29, Russell King - ARM Linux admin wrote: > On Thu, Jun 04, 2020 at 10:26:27AM +0100, Valentin Schneider wrote: >> >> On 04/06/20 01:48, Thara Gopinath wrote: >> > Hi Russel/Valentin >> > >> > The feature itself like Valentin explained below allows scheduler to be >> > aware of cpu capacity reduced due to thermal throttling. >> > arch_set_thermal_pressure feeds the capped capacity to the scheduler and >> > hence the feature makes sense only if arch_set_thermal_pressure is >> > implemented. Having said that arch_set_thermal_pressure is implemented >> > in arch_topology driver for arm and arm64 platforms. But the feature >> > itself is not bound to arm/arm64 platforms. So it would make it wrong to >> > add a "depends on (ARM || ARM64) option." >> > >> > I agree with Vincent that allowing user to choose this option is >> > probably not the best. IMO, this should be enabled by default in arm64 >> > defconfig considering both GENERIC_ARCH_TOPOLOGY and CPU_FREQ_THERMAL >> > are enabled by default. >> >> Right, I had skimmed over that but it probably does make more sense not >> to bother users with it. >> >> > So if it is acceptable three things to be done are: >> > 1. Add the help text. >> > 2. Don't allow SCHED_THERMAL_PRESSURE configurable by user >> > 3. Enable it by default in arm64 defconfig >> >> ... and arm as well, I suppose? > > If it's not a user visible option, then there's no point it being in > defconfig. Right, s/defconfig/arch kconfig/ or somesuch.