mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Thara Gopinath <thara.gopinath@linaro.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: v5.7: new core kernel option missing help text
Date: Wed, 03 Jun 2020 19:00:26 +0100	[thread overview]
Message-ID: <jhjh7vshvwl.mognet@arm.com> (raw)
In-Reply-To: <20200603173150.GB1551@shell.armlinux.org.uk>


On 03/06/20 18:31, Russell King - ARM Linux admin wrote:
> Hi,
>
> A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was
> recently added, but has no help text. This is most unhelpful when
> trying to configure the kernel, since one does not know what the
> effect of answering yes or no to this option would be.
>
> Please supply a proper help text when adding core kernel options
> so that people can make an informed decision when answering the
> prompt, rather than just guessing.
>

Right; does the below look good enough?

---
diff --git a/init/Kconfig b/init/Kconfig
index 74a5ac65644f..f40cf852d00a 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -441,6 +441,10 @@ config HAVE_SCHED_AVG_IRQ
 config SCHED_THERMAL_PRESSURE
        bool "Enable periodic averaging of thermal pressure"
        depends on SMP
+	help
+	  This option allows the scheduler to be aware of CPU thermal throttling
+	  (i.e. thermal pressure), providing arch_scale_thermal_pressure() is
+	  implemented.

 config BSD_PROCESS_ACCT
        bool "BSD Process Accounting"
---

  reply	other threads:[~2020-06-03 18:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 17:31 Russell King - ARM Linux admin
2020-06-03 18:00 ` Valentin Schneider [this message]
2020-06-03 18:45   ` Russell King - ARM Linux admin
2020-06-03 19:24     ` Vincent Guittot
2020-06-03 19:58       ` Russell King - ARM Linux admin
2020-06-03 20:22         ` Vincent Guittot
2020-06-03 20:25         ` Valentin Schneider
2020-06-04  0:48           ` Thara Gopinath
2020-06-04  9:26             ` Valentin Schneider
2020-06-04  9:29               ` Russell King - ARM Linux admin
2020-06-04 10:56                 ` Valentin Schneider
     [not found]                   ` <CALD-y_zQms4YQup2MgAfNhWSu=ewkhossHma2TKqfTcOFaG=uA@mail.gmail.com>
2020-06-04 15:38                     ` Valentin Schneider
2020-06-04 22:22                       ` Thara Gopinath
2020-06-05  7:03                       ` Vincent Guittot
2020-06-05  9:46                         ` Valentin Schneider
2020-06-05  8:15                       ` Russell King - ARM Linux admin
2020-06-05 10:02                         ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jhjh7vshvwl.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome