mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Tomlin <atomlin@atomlin.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
	 "Moger, Babu" <bmoger@amd.com>,
	"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
	 "james.morse@arm.com" <james.morse@arm.com>,
	"babu.moger@amd.com" <babu.moger@amd.com>,
	 "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	 "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	 "sean@ashe.io" <sean@ashe.io>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains
Date: Thu, 25 Dec 2025 17:50:19 -0500	[thread overview]
Message-ID: <js2hrscjtioxvfe2la3ycf43cuj536smsj4voecl5ps3xpit2j@qi4rh5mgttpd> (raw)
In-Reply-To: <aUXaPsCeikFVy6ra@agluck-desk3>

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

On Fri, Dec 19, 2025 at 03:05:34PM -0800, Luck, Tony wrote:
> I still don't see a good reason for the kernel to handle any of this.
> 
> Having some resctrl control files accept wildcards while others don't
> seems like a confusing interface. Is there something I'm missing that
> makes io_alloc harder for users to handle than L3 or MB in schemata?
> 
> Babu's simpler implementation for io_alloc makes me more comfortable
> with this. But I'm still unconvinced that wildcards must be handled
> in kernel code.

Hi Tony,

I appreciate your reservations regarding where the responsibility for such
abstractions should lie. However, I am of the view that forcing the user to
manually specify every domain for a global policy represents an unnecessary
hurdle that the kernel is uniquely positioned to clear.

I shall indeed employ Babu's suggestion in a follow-up patch for review, as
the resulting simplicity of the implementation should, I hope, alleviate
any concerns regarding the addition of technical debt.


Kind regards,
-- 
Aaron Tomlin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-12-25 22:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 23:02 [PATCH v2 0/3] " Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state Aaron Tomlin
2025-12-17  5:01   ` Reinette Chatre
2025-12-18 23:22     ` Aaron Tomlin
2025-12-19 17:05       ` Reinette Chatre
2025-12-25 22:23         ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin
2025-12-17  5:02   ` Reinette Chatre
2025-12-18 23:12     ` Aaron Tomlin
2025-12-15 23:02 ` [PATCH v2 3/3] x86/resctrl: Add "*" shorthand to set minimum io_alloc CBM for all domains Aaron Tomlin
2025-12-17  5:53   ` Reinette Chatre
2025-12-19  0:21     ` Aaron Tomlin
2025-12-18 21:32   ` Moger, Babu
2025-12-18 21:49     ` Luck, Tony
2025-12-18 21:56       ` Moger, Babu
2025-12-19  0:31         ` Aaron Tomlin
2025-12-19  0:40           ` Moger, Babu
2025-12-18 22:59       ` Reinette Chatre
2025-12-19  0:44         ` Aaron Tomlin
2025-12-19 18:28           ` Reinette Chatre
2025-12-19 20:42             ` Luck, Tony
2025-12-19 22:00               ` Reinette Chatre
2025-12-19 23:05                 ` Luck, Tony
2025-12-25 22:50                   ` Aaron Tomlin [this message]
2025-12-25 22:33             ` Aaron Tomlin
2025-12-19  0:26     ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=js2hrscjtioxvfe2la3ycf43cuj536smsj4voecl5ps3xpit2j@qi4rh5mgttpd \
    --to=atomlin@atomlin.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=sean@ashe.io \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®