mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dongjin Kim <tobetter@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Change ethernet TXD timing delay value
Date: Wed, 03 Sep 2025 12:10:46 -0400	[thread overview]
Message-ID: <jwvseh3v8n5.fsf-monnier+@gnu.org> (raw)
In-Reply-To: <aKU2yYD+N2D1KuHk@anyang>

Dongjin Kim wrote:
> On Tue, Aug 19, 2025 at 06:03:47PM +0200, Andrew Lunn wrote:
> > On Tue, Aug 19, 2025 at 01:50:17PM +0900, Dongjin Kim wrote:
> > > Very poor network performance is observed on the ODROID-M1 Board
> > > (REV 1.0 20220613) when running iperf3 (under 200Mbits/sec), and
> > > this problem can be resolved after changing the value of TXD
> > > timing to 0x35 from 0x4f.
> > 
> > How did you decide on 0x35?
> > 
> > ~/linux/arch/arm64$ grep -hr "tx_delay = " | sort | uniq -c
> >       4 	tx_delay = <0x10>;
> >       1 	tx_delay = <0x1a>;
> >       1 	tx_delay = <0x21>;
> >       2 	tx_delay = <0x22>;
> >       4 	tx_delay = <0x24>;
> >       2 	tx_delay = <0x26>;
> >      14 	tx_delay = <0x28>;
> >       1 	tx_delay = <0x2a>;
> >       6 	tx_delay = <0x30>;
> >       1 	tx_delay = <0x3a>;
> >       3 	tx_delay = <0x3c>;
> >       2 	tx_delay = <0x42>;
> >       5 	tx_delay = <0x43>;
> >       2 	tx_delay = <0x44>;
> >       1 	tx_delay = <0x46>;
> >       6 	tx_delay = <0x4f>;
> > 
> > The numbers are all over the place, but it is clear that 0x28 is the
> > most popular for some reason. But since this delay values are magic,
> > i've no idea why.
> > 
> >      Andrew
> I do have more numbers in the Rockchip BSP kernel, and 0x35 is from
> one of them that shows less retry counts when testing 'iperf3' while
> testing with the batch of ODROID-M1. :)

FWIW, I had trouble with my Odroid-M1 whose outgoing ethernet bandwidth
seemed to be limited to an average around 100kB/s, when I bumped into
this thread.  I applied the patch and I can now download from that
Odroid at >80MB/s.  So:

    Tested-by: Stefan Monnier <monnier@iro.umontreal.ca>

Haven't tried the `rgmii-id` patch yet.


        Stefan


      reply	other threads:[~2025-09-03 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19  4:50 Dongjin Kim
2025-08-19  6:42 ` Krzysztof Kozlowski
2025-08-19  7:48   ` Dongjin Kim
2025-08-19 16:03 ` Andrew Lunn
2025-08-19 18:44   ` Heiko Stübner
2025-08-20  2:45   ` Dongjin Kim
2025-09-03 16:10     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvseh3v8n5.fsf-monnier+@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®