From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C87612571C7 for ; Sat, 6 Jun 2026 18:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780771240; cv=pass; b=FBlnLym2ncGXo8jI0xBU8l82qGSqEp5qc3XqzcWWwOmbAqXbbbgoXKAeIrhO+EkEc5Yeo2c8Kka9L+Zfk+yCGKYj6W5MoYFB4+Q9oToOw5Dd/+kmNasicmsxDq0/ww6D7dgzmiev9LKr7hhYoiwBq3NGePPJvQB2Z6CPJaienJ4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780771240; c=relaxed/simple; bh=FZP0kKifadW64XQHyvshoHC/VkWLd7mAtqFp8jQB4JM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P7Nv9e9QLAq10onPfC4FL+d35GdAvFN7odSe2io5stXUPpf652yRTc4JkazKQE9dCK2jdykI3w6C/wCh7Ezk5nMWA6O1tYcKbO0VkmpkxCYVcLjsgxNPubZOo53f+8aFatHK/68H4soGh07E1BhX9nJm5D+DzjkFqSbfsz4UZ1A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=EW2TQW2i; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="EW2TQW2i" ARC-Seal: i=1; a=rsa-sha256; t=1780771190; cv=none; d=zohomail.com; s=zohoarc; b=PqpQa88e5bwqmcaFA652JDeAPdo+EOirG8JoaGnOdeGMNiVLJ5Uzlpl218WxKgCy8unw/EIiMKfax7XKf75o2ThaNP19cCBDN8jZKEDfapoCdv/2wfUAoJ1Qwiz3CnPrxS08u3/phM4ZZUdvttFLm+nSyF76FiS+xHG/05CFeik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780771190; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=IBRJ5xkb51o4nAEKxK2DLYLkB7ZAohg6NhCUWzAEfEY=; b=DCGaDpLYVGoeQHJFRHM1S9Ns+VL2jKdFAQFqcExWgx1TFK6rd+8lcfoyJvoHetPxJHdk7joun4R64wt6k8CZEqELXDKcYv4ExKEO2/cVdl0YbqXHceOJmpZYbSdNmojqYFWuC+Bb7g+6qamZEWTNqJiy8xxm4FuSfj8dvhqHwCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1780771190; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=IBRJ5xkb51o4nAEKxK2DLYLkB7ZAohg6NhCUWzAEfEY=; b=EW2TQW2ik9fFVdgLR0PbTgjVTmfoNOG5VpEV5TzF4FPSFQasfiLv2mUKGlyrHssn WUSgQ4nQr6e/320sZagA2tq1qlqYxbup/yc0JmOmgDppnS2F5AHDOwfBbrUVsq27gwD E/muLbn7oa/shoyqZQ2/zPhHSeoSPHdUlbDk4VM4= Received: by mx.zohomail.com with SMTPS id 1780771187168175.71050321767996; Sat, 6 Jun 2026 11:39:47 -0700 (PDT) From: Nicolas Frattaroli To: Maxime Ripard Cc: Jani Nikula , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Daniel Stone , Hans Verkuil , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Daniel Stone Subject: Re: [PATCH v5 3/4] drm/display: bridge_connector: init scdc debugfs for HDMI Date: Sat, 06 Jun 2026 20:39:39 +0200 Message-ID: In-Reply-To: <20260606-bright-smooth-chihuahua-3eac7f@houat> References: <20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com> <20260604-scdc-link-health-v5-3-11173b0ac3de@collabora.com> <20260606-bright-smooth-chihuahua-3eac7f@houat> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Saturday, 6 June 2026 10:54:23 Central European Summer Time Maxime Ripard wrote: > Hi, > > On Thu, Jun 04, 2026 at 05:52:08PM +0200, Nicolas Frattaroli wrote: > > On drm_bridge_connectors that contain an HDMI bridge, initialise the > > SCDC debugfs entry under the connector's debugfs root. > > > > Reviewed-by: Daniel Stone > > Signed-off-by: Nicolas Frattaroli > > --- > > drivers/gpu/drm/display/drm_bridge_connector.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c > > index cafa498c3848..629d9b8aff22 100644 > > --- a/drivers/gpu/drm/display/drm_bridge_connector.c > > +++ b/drivers/gpu/drm/display/drm_bridge_connector.c > > @@ -25,6 +25,7 @@ > > #include > > #include > > #include > > +#include > > > > /** > > * DOC: overview > > @@ -263,6 +264,9 @@ static void drm_bridge_connector_debugfs_init(struct drm_connector *connector, > > if (bridge->funcs->debugfs_init) > > bridge->funcs->debugfs_init(bridge, root); > > } > > + > > + if (bridge_connector->bridge_hdmi) > > + drm_scdc_debugfs_init(connector, root); > > } > > We register the other debugfs entries in drm_debugfs_connector_add / > hdmi_debugfs_add. I don't think there's anything specific to bridge > connector here and it would benefit to drivers that don't use it as > well, so I think putting it in the generic part of the framework would > be better. Yeah, I tried that, but unfortunately this creates a dependency cycle during linking: depmod: ERROR: Cycle detected: drm_display_helper -> drm_kms_helper -> drm -> drm_display_helper depmod: ERROR: Cycle detected: drm_display_helper -> drm -> drm_display_helper depmod: ERROR: Found 3 modules in dependency cycles! My way of working around this was to move it into the target of the indirect function call for the connector, in this case the bridge connector. If you have alternate suggestions I'm open to them; I don't know enough about the kernel's linking process and how people usually resolve these issues. Kind regards, Nicolas Frattaroli > > Maxime >