mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Michael Kelley <mhklinux@outlook.com>,
	Mukesh R <mrathor@linux.microsoft.com>,
	Michael Kelley <mhklinux@outlook.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	"decui@microsoft.com" <decui@microsoft.com>,
	"kameroncarr@linux.microsoft.com"
	<kameroncarr@linux.microsoft.com>
Subject: RE: [PATCH V1 2/2] Drivers: hv: Fix bugs and issues around repeat hypercall
Date: Thu, 19 Nov 2026 11:28:24 +0100	[thread overview]
Message-ID: <kupqzghglo7.fsf@vkuznets-thinkpadx1carbongen12.rmtcz.csb> (raw)
In-Reply-To: <MN2PR02MB6863A95F4A2E10D73BDBFE97D47A2@MN2PR02MB6863.namprd02.prod.outlook.com>

Michael Kelley <mhklinux@outlook.com> writes:

> From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Wednesday, November 18, 2026 6:02 AM
>> 
>> Mukesh R <mrathor@linux.microsoft.com> writes:
>> 
>> > On 11/17/26 09:41, Michael Kelley wrote:
>> 
>> ...
>> 
>> > Confirming, that it is same behavior all the way back to 2016.
>> >
>> >> Sounds good. FWIW, old TLFS version 2.0A, which is specifically
>> >> titled to cover Windows Server 2008 R2, has the paragraph
>> >> about hypercall continuation. So that functionality was evidently
>> >> present very early on. It is still curious that Vitaly found it
>> >> necessary to include the looping behavior in the Linux guest
>> >> code.
>> >
>> > Maybe Vitaly was running into a genuine bug, not sure.
>> >
>> 
>> I'm not sure either :-(
>> 
>> WS2012 was definitely around back then, not sure about 2008. It may also
>> make sense to add at least a debug print in case we find ourselves
>> running on something that old. AFAICS, even the TLFS version 2.0A
>> mentions PV TLB flush hypercalls. If looping is still required for these
>> old versions, we may introduce some very hard-to-find bugs if we drop
>> it.
>> 
>
> Vitaly -- I'll point out that support for running Linux guests
> on any Hyper-V older than WS2016/Win10 has been removed
> from the upstream code tree as of 7.4. 

Missed that, thanks for pointing out!

> The removal is
> impactful enough that 7.4 and later kernels won't boot in a
> guest on these older Hyper-V versions. Hopefully whatever bug
> you encountered is no longer present in WS2016 and later. But
> even if the looping is removed, the code could still check and
> warn on a hypercall completion with no error but not all reps
> completed. Then at least we'd know there is a problem.

Yes, WARN[_ON_ONCE]() should be sufficient.

-- 
Vitaly


  reply	other threads:[~2026-11-19 10:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  2:53 [PATCH V1 0/2] Hyper-V: " Mukesh R
2026-11-14  2:53 ` [PATCH V1 1/2] Drivers: hv: Add new function hv_isolation_type_hw() Mukesh R
2026-11-14  2:53 ` [PATCH V1 2/2] Drivers: hv: Fix bugs and issues around repeat hypercall Mukesh R
2026-11-15 23:48   ` Michael Kelley
2026-11-16 16:53     ` Vitaly Kuznetsov
2026-11-17  2:29     ` Mukesh R
2026-11-17 17:41       ` Michael Kelley
2026-11-17 23:09         ` Mukesh R
2026-11-18 14:01           ` Vitaly Kuznetsov
2026-11-18 16:57             ` Michael Kelley
2026-11-19 10:28               ` Vitaly Kuznetsov [this message]
2026-11-20  1:31         ` Mukesh R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kupqzghglo7.fsf@vkuznets-thinkpadx1carbongen12.rmtcz.csb \
    --to=vkuznets@redhat.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kameroncarr@linux.microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=mrathor@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®