From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f16.google.com (mail-dy2-f16.google.com [74.125.229.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8913D204C31 for ; Mon, 5 Oct 2026 03:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791171821; cv=none; b=qnLFp3TD2kXu/8ys9PEy1vmShjMaWc+Sa9MCzSlpkagSAcqtD6u6Tz9Wq6DLW5CM3Z05088sH3yrFHztDIzK+MWkAcW4U9EnPGHuQ0gsODHGdaoTDLBoFym195PsWftxoNl41jNVC0GqewdEWfPl7jaxIe4F2BaxpkHnyQR38VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791171821; c=relaxed/simple; bh=kLBUT6vlOnJkls8hhLvjNyrBIlLdYaeftYindRKhgaA=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=g8KHvTB5rxkX1ZdwnSbGi+qSmXmUBlJPqvL+YVw7xzSIOkmszjTaWO8CEVe75zNQ6IofM/B3QaJL9GbUs8pCkjNFNmJjp+r15rNvlp/UXj7sc0Y1SlfBMdCYguT3Z0IMd2Vgbc/HFVHhpgf2kYyvB6hIrNWebp+yCTN2CypQU6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lR42R7j1; arc=none smtp.client-ip=74.125.229.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lR42R7j1" Received: by mail-dy2-f16.google.com with SMTP id 5a478bee46e88-34b3a9cd8edso591070eec.1 for ; Sun, 04 Oct 2026 20:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791171819; x=1791776619; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=M3GmJfAIymRvAtsrt3eqOBHmB18YZ66xoxLnv39f0iU=; b=lR42R7j1VVdY1DnH2shetr7+ZOrrKXL0yQi/LZc5yZM2WUVeV9l1vsT+lYzByhOEKX HZk/tnMWWqVagknHqpCsGl578XhygdEOR+JxuZDwoXa4BlsVe5BoE9FQsdWbJhMlwmr9 7WnigxdfDwAYXJ7XisQUK0VId9dxwzcQNdAC4343AQO5CFmbFUohLrN2vIhTRubLyAjS 29jSHYaAevvvppx8gw50dDEUfNup2/Vm8/BklxM8j+GMyIOK6WPR8oiKDii7VoGLnraS UdlGEewwK+taMn+8QClxAxjF8jdEM1z4eUeehjvrfuzOwWqexjM8/s/WLOZ9tLWwEJay Jxgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791171819; x=1791776619; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M3GmJfAIymRvAtsrt3eqOBHmB18YZ66xoxLnv39f0iU=; b=QgZjXGZc5Hs7Ak/bAgnhkVgy5p771aqMP5xACMQrHXtYfDZR11heB3CB7+tDC/ruIC VDmbXGVPRcgYrElU6kpqaIMF3TWJkO0xdLGECiUsTzBEyyU5bBrVaDClrdpnUEgLnvgH Cca+BzahDx6T8aGURkjZu8W72W/SEEsUpi71sWNEjELjrn+mTaquLpOZmfBkGb+d4W2b tMkuNE30VRIPf0HwPfqDy4lCxr75C0UH6H9RXBgTZVsjZsIiTk6YtU+r+pOFjBH3pqoZ c+3uQJUDVdCpP7a5ZiWl2RgfsEukp5imPigH2X0yNEzptquyBNdLi/1eFvJjKxCjqmoO uZmQ== X-Forwarded-Encrypted: i=1; AKwUvByobeAT6onV4+A6Ng+onVoKMV4dNX7sjGgtVmU7Q+ettKk3sxEDlZebuWhrYYzXZERdPvA554GLGgg2q2g=@vger.kernel.org X-Gm-Message-State: AFq9FYJ0bD4NyRyUIywH78TXQQKeOONpNRyMA448igly5SKIGvvP3T6Z LN7t4/9nnOMdgz7CYwDUEDLh0J4hZevwwxCeknqY7cInHP4iEedAb9ui X-Gm-Gg: AYBFou3nKR6sG/82/tns9Tv1rxzMvxC/TDh/YcEUeC9MlVBQEy5MM5PbyRVZLS7/X8N RcDrKrvLmf0lWp4XBEN+f990KdvKHqGoPNxeOd18HVeQkZ2g7EyBdonIVCu9iaMpHnF6PKpO2in qlA/wpWrYxGZKc/+rQ5OcnK2rfMUmR+FYE5/IYFRikZkT0EDSjLN2Fdjetw6j9pmmydgsQ3AM+3 17+PDyllarvcRRanD6mHZcTaV8c4kG6D42/72wNoiYly3dy3BZaAieVXp+GNm4OT3XfFboHvMDs jt2N6KnMdyOGXks2ygo3/hbS4yGVfm1nPS9dwDL4RBvl2aMzAgCzijgvf5aJwqYbsOepsAI3g4q 6wOJpeYSligLwqPJb1grjrPehrmNl/VOrRHCakO1+HrrSNSIebtUvXIGMf/TMHjNndTu2tC/AbU ow0fQS5imIeJtnEs1qS+ovesH/RDxhq9VeYkkYeFvoOtYVtJOKgmO+FM1WW9hZ7VISK2aLlvL+y Iy6qj/bjAA11wgCJuHL0Ewxpqwe3XT35332IQpZWTvg6BcwNvu7Lg== X-Received: by 2002:a05:693c:65c5:b0:33c:43c:f3dd with SMTP id 5a478bee46e88-34f2196cd67mr10917502eec.11.1791171819348; Sun, 04 Oct 2026 20:43:39 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3512717cc1esm9601422eec.16.2026.10.04.20.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 20:43:38 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson Cc: kvm@vger.kernel.org, Paolo Bonzini , linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Christophe Leroy , Anushree Mathur , Venkat Rao Bagalkote , Harsh Prateek Bora , Madhavan Srinivasan , Shrikanth Hegde , linux-kernel@vger.kernel.org, Nicholas Piggin Subject: Re: [PATCH v5 1/9] KVM: PPC: selftests: add support for powerpc In-Reply-To: Date: Sat, 03 Oct 2026 10:07:11 +0530 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Sean Christopherson writes: > On Tue, Sep 22, 2026, Ritesh Harjani (IBM) wrote: >> --- >> MAINTAINERS | 2 + >> tools/testing/selftests/kvm/Makefile | 2 +- >> tools/testing/selftests/kvm/Makefile.kvm | 10 + >> .../testing/selftests/kvm/include/kvm_util.h | 9 + >> .../selftests/kvm/include/powerpc/hcall.h | 17 + >> .../kvm/include/powerpc/kvm_util_arch.h | 22 + >> .../selftests/kvm/include/powerpc/ppc_asm.h | 32 ++ >> .../selftests/kvm/include/powerpc/processor.h | 39 ++ >> .../selftests/kvm/include/powerpc/ucall.h | 21 + >> tools/testing/selftests/kvm/lib/guest_modes.c | 20 +- >> tools/testing/selftests/kvm/lib/kvm_util.c | 8 + >> .../selftests/kvm/lib/powerpc/handlers.S | 93 ++++ >> .../testing/selftests/kvm/lib/powerpc/hcall.c | 45 ++ >> .../selftests/kvm/lib/powerpc/processor.c | 512 ++++++++++++++++++ >> .../testing/selftests/kvm/lib/powerpc/ucall.c | 22 + >> 15 files changed, 851 insertions(+), 3 deletions(-) >> create mode 100644 tools/testing/selftests/kvm/include/powerpc/hcall.h >> create mode 100644 tools/testing/selftests/kvm/include/powerpc/kvm_util_arch.h >> create mode 100644 tools/testing/selftests/kvm/include/powerpc/ppc_asm.h >> create mode 100644 tools/testing/selftests/kvm/include/powerpc/processor.h >> create mode 100644 tools/testing/selftests/kvm/include/powerpc/ucall.h >> create mode 100644 tools/testing/selftests/kvm/lib/powerpc/handlers.S >> create mode 100644 tools/testing/selftests/kvm/lib/powerpc/hcall.c >> create mode 100644 tools/testing/selftests/kvm/lib/powerpc/processor.c >> create mode 100644 tools/testing/selftests/kvm/lib/powerpc/ucall.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index fc320b373656..35df0c39e991 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -14349,6 +14349,8 @@ F: arch/powerpc/include/asm/kvm* >> F: arch/powerpc/include/uapi/asm/kvm* >> F: arch/powerpc/kernel/kvm* >> F: arch/powerpc/kvm/ >> +F: tools/testing/selftests/kvm/*/powerpc/ >> +F: tools/testing/selftests/kvm/powerpc/ > > I don't think sending KVM PPC selftests changes through the PPC tree will work. > It's "fine" for KVM PPC changes because the volume of KVM PPC changes is low and > rarely modifies anything outside of arch/powerpc. > > KVM selftests tend to have a lot more cross-arch and/or common code modifications, > i.e. I think we'll be setting ourselves up for pain if we don't route all KVM > selftests changes through Paolo's tree. > Sure, since enabling kvm selftests on powerpc has quite a few common changes in cross-arch, so it make sense to take it via common tree which it already uses. BTW - the above file name paths are just so that we can have people cc linuxppc-dev too, for powerpc kvm selftests changes. > Does it maybe make sense to have all of KVM PPC route through Paolo? Punting to > PPC made sense when KVM PPC was on life support, but it looks like resuscitation > was successful for at least some flavors of KVM PPC? Today, I think it is getting managed, as long as the core/UAPI changes are routed via Paolo and/or via ACK from both maintainers. However, for PPC kvm selftests - let's do as discussed - to take it via common kvm tree. Thanks again Sean, for the review. I will soon post v6 with the suggested approach. -ritesh