mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikolas Koesling <nikolas@koesling.info>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Aryan Sinha <sinha.aryan03@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aryan Sinha <sinha.aryan03@gmail.com>
Subject: Re: [PATCH] HID: pulsar: print the battery error with %pe
Date: Thu, 05 Nov 2026 14:08:37 +0100	[thread overview]
Message-ID: <ldaTdNN0R-CJNS6mWTaQdg@koesling.info> (raw)
In-Reply-To: <20261104150055.33028-1-sinha.aryan03@gmail.com>

Hi Aryan,

thanks for the patch, the change itself looks good.
However, it only converts one of the error prints in the driver. The remaining
ones still print the plain errno with %d. they can use %pe with ERR_PTR(ret)
as well.
Could you send a v2 that converts all of them, so the driver reports errors
consistently?

Thanks,
Nikolas




      reply	other threads:[~2026-11-05 13:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:00 Aryan Sinha
2026-11-05 13:08 ` Nikolas Koesling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ldaTdNN0R-CJNS6mWTaQdg@koesling.info \
    --to=nikolas@koesling.info \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sinha.aryan03@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®