From: Antonio Amorim <Antonio.Amorim@paipix.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.13 flocks_remove_flock hits BUG();
Date: Mon, 12 Sep 2005 16:40:01 +0000 (UTC) [thread overview]
Message-ID: <loom.20050912T183812-156@post.gmane.org> (raw)
In-Reply-To: <20050902145049.9E6E633CDA@rekin5.o2.pl>
Jakub W. Jozwicki <jakub007@...> writes:
>
> Because of incomplete conditional flocks_remove_flock runs into
> BUG() which is below 'ifs'. This was visible with using unionfs.
>
> --- locks.c 2005-09-02 16:38:40.770509784 +0200
> +++ locks-fixed.c 2005-09-02 16:37:22.000000000 +0200
> <at> <at> -1908,7 +1908,7 <at> <at>
>
> while ((fl = *before) != NULL) {
> if (fl->fl_file == filp) {
> - if (IS_FLOCK(fl)) {
> + if (IS_FLOCK(fl) || IS_POSIX(fl)) {
> locks_delete_lock(before);
> continue;
> }
>
What was the UNIONFS version that you were able to compile with the 2.6.13
kernel. Did it work ok after applying the patrch?
All the best,
Antonio Amorim
parent reply other threads:[~2005-09-12 17:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20050902145049.9E6E633CDA@rekin5.o2.pl>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20050912T183812-156@post.gmane.org \
--to=antonio.amorim@paipix.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®