From: Guenter Roeck <guenter.roeck@ericsson.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case
Date: Fri, 24 Sep 2010 04:43:34 +0000 (UTC) [thread overview]
Message-ID: <loom.20100924T063847-735@post.gmane.org> (raw)
In-Reply-To: <4C8E139F0200007800015AA5@vpn.id2.novell.com>
Jan Beulich <JBeulich <at> novell.com> writes:
>
> In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to
> platform_driver_unregister() was made conditional upon !HOTPLUG_CPU,
> but the return value from coretemp_init() was left to indicate an
> error. This isn't correct, as the negative return value indicates to
> the module loader that initialization failed, which isn't intended
> here and results in dangling pointers.
>
> Signed-off-by: Jan Beulich <jbeulich <at> novell.com>
> Cc: Chen Gong <gong.chen <at> linux.intel.com>
>
I have not seen an Acked-by or Nacked-by for this patch or any other patch from
this series from Jan.
Discussions indicate that the patches are ok. Unless I hear an explicit Nack,
I'll review the patches and apply them if I think they make sense.
Guenter
next prev parent reply other threads:[~2010-09-24 4:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 10:05 Jan Beulich
2010-09-14 6:30 ` [lm-sensors] " Chen Gong
2010-09-14 6:47 ` Jan Beulich
2010-09-14 7:46 ` Chen Gong
2010-09-14 8:19 ` Jan Beulich
2010-09-24 4:43 ` Guenter Roeck [this message]
2010-09-24 18:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100924T063847-735@post.gmane.org \
--to=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome