From: Guenter Roeck <guenter.roeck@ericsson.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/hwmon: don't leak device attribute file from pkgtemp_probe()
Date: Fri, 24 Sep 2010 05:02:28 +0000 (UTC) [thread overview]
Message-ID: <loom.20100924T065409-7@post.gmane.org> (raw)
In-Reply-To: <4C8E15B30200007800015AC9@vpn.id2.novell.com>
Jan Beulich <JBeulich <at> novell.com> writes:
>
> While apparently inherited from coretemp source, this particular error
> handling cleanup path wasn't copied properly (or perhaps got discarded
> intermediately and not re-added properly later).
>
> Signed-off-by: Jan Beulich <jbeulich <at> novell.com>
> Cc: Fenghua Yu <fenghua.yu <at> intel.com>
>
> ---
[...]
> exit_class:
> sysfs_remove_group(&pdev->dev.kobj, &pkgtemp_group);
> +exit_dev:
> + device_remove_file(&pdev->dev, &sensor_dev_attr_temp1_max.dev_attr);
> exit_free:
> kfree(data);
> exit:
>
The device file should also be deleted in pkgtemp_remove(). Looks like that got
lost as well.
No need to resend; I'll add that myself.
Guenter
prev parent reply other threads:[~2010-09-24 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 10:14 Jan Beulich
2010-09-24 5:02 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20100924T065409-7@post.gmane.org \
--to=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome