mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: el es <el.es.cr@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [REVIEW] NVM Express driver
Date: Fri, 4 Mar 2011 09:02:33 +0000 (UTC)	[thread overview]
Message-ID: <loom.20110304T095238-128@post.gmane.org> (raw)
In-Reply-To: <4D704DAB.9080100@mit.edu>

Andy Lutomirski <luto <at> MIT.EDU> writes:

> 

> > I didn't even realize we had a firmware README file...
> >
> > Anyway, just use request_firmware_nowait(), you will be fine.
> >
> 
> Unless I'm misunderstanding the spec, this is for *nonvolatile* firmware 
> updates.  So if I have two of these devices and I stick a firmware file 
> into /lib/firmware, should it update both devices?
> 
> Shouldn't reflashing the device firmware be something that the users 
> asks for by something a little more specific than just creating a file? 
>   (In any case, creating /lib/firmware/nvmhci-3 to flash slot 3 seems 
> rather silly.)
> 

_lame user warning on_

if module is built-in, maybe something like /sys/class/nvm/driveX/fw_path could
receive the _path_ to firmware, so that writing to it (either/or writing to
hypothetical /sys/class/nvm/driveX/fw_do_update) would trigger the flashing
procedure, and reading it would provide _human readable_ flashing progress
information ?

If module is complied, well, as a module, could be invoked with the fw_path
parameter and the fw_do_update parameter as the safety flag.

With appropriate safety measures, like making sure drive is unmounted, queue is
empty and so on, ensured in userspace?

> --Andy
> 

el es



  reply	other threads:[~2011-03-04  9:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 20:47 Matthew Wilcox
2011-03-03 21:13 ` Greg KH
2011-03-03 21:41   ` Matthew Wilcox
2011-03-03 21:51     ` Greg KH
2011-03-03 22:07       ` Matthew Wilcox
2011-03-03 22:22         ` Greg KH
2011-03-04  2:25           ` Andy Lutomirski
2011-03-04  9:02             ` el es [this message]
2011-03-04 21:29             ` Greg KH
2011-03-04 12:43           ` Alan Cox
2011-03-04 21:28             ` Greg KH
2011-03-04 21:59               ` Alan Cox
2011-03-04 22:10                 ` Greg KH
2011-03-04 22:33                   ` Alan Cox
2011-03-04 23:10                     ` Greg KH
2011-03-05 10:28                       ` Alan Cox
2011-03-04 12:52     ` Mark Brown
2011-03-03 21:33 ` Randy Dunlap
2011-03-04 13:06 ` Christoph Hellwig
2011-03-04 14:46   ` Matthew Wilcox
2011-03-11 22:29 ` Andi Kleen
2011-03-12  5:51   ` Matthew Wilcox
2011-03-13 17:14     ` Andi Kleen
2011-03-13 18:24 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20110304T095238-128@post.gmane.org \
    --to=el.es.cr@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome