From: "Christian König" <deathsimple@vodafone.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dvb-core: fix DVBFE_ALGO_HW retune bug
Date: Thu, 8 Mar 2012 22:26:54 +0000 (UTC) [thread overview]
Message-ID: <loom.20120308T231756-162@post.gmane.org> (raw)
In-Reply-To: <4F304CAD.5080700@simon.arlott.org.uk>
Simon Arlott <simon <at> fire.lp0.eu> writes:
>
> Commit 7e07222 breaks DVBFE_ALGO_HW tuning after a retune is requested,
> which causes bad tuning on my TBS 6920.
>
> [ 0.769091] pci 0000:06:00.0: [14f1:8852] type 0 class 0x000400
> [ 19.733530] CORE cx23885[0]: subsystem: 6920:8888, board: TurboSight TBS
6920 [card=14,autodetected]
> [ 762.824912] cx24116_load_firmware: FW version 1.23.86.1
>
> 7e0722215a510921cbb73ab4c37477d4dcb91bf8 [media] dvb-core: Don't pass DVBv3
parameters on tune() fops
>
> Although re_tune is set to true when FESTATE_RETUNE occurs, it is never
> set back to false which the old code used to do when !FESTATE_RETUNE.
>
> This patch sets re_tune to false if !(state & FESTATE_RETUNE).
>
[snip]
>
> Signed-off-by: Simon Arlott <simon <at> fire.lp0.eu>
Please make sure that this patch is pushed upstream, since the patch who
introduced the bug is already in 3.3-rc6 but not this fix. Otherwise:
Tested by: Christian König <deathsimple@vodafone.de
prev parent reply other threads:[~2012-03-08 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 21:57 Simon Arlott
2012-03-08 22:26 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20120308T231756-162@post.gmane.org \
--to=deathsimple@vodafone.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome