mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wladislav Wiebe <wladislav.kw@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mips: function tracer: Fix broken function tracing
Date: Tue, 2 Apr 2013 11:12:16 +0000 (UTC)	[thread overview]
Message-ID: <loom.20130402T131118-818@post.gmane.org> (raw)
In-Reply-To: <1358436945.23211.10.camel@gandalf.local.home>

Hi,

I have a bad experience with MIPS 64 Bit Architecture on Kernel 3.8.
The Kernel doesn't boot when enabling CONFIG_FUNCTION_TRACER,
it hangs at early startup directly after u-boot init:

..
## Loading Linux kernel with entry point: 0xffffffff805e23c0 ...
Bootloader: Done loading app on coremask: 0x3f
setting up named block for __uboot_log at 0xfcf4000
...

Basically, I temporary workaround it with 
diff --git a/linux/arch/mips/kernel/mcount.S b/linux/arch/mips/kernel/mcount.S
index 1658676..4438c74 100644
--- a/linux/arch/mips/kernel/mcount.S
+++ b/linux/arch/mips/kernel/mcount.S
@@ -46,9 +46,8 @@
        PTR_L   a5, PT_R9(sp)
        PTR_L   a6, PT_R10(sp)
        PTR_L   a7, PT_R11(sp)
-#else
-       PTR_ADDIU       sp, PT_SIZE
 #endif
+       PTR_ADDIU       sp, PT_SIZE
 .endm
 
        .macro RETURN_BACK
@@ -68,7 +67,11 @@ NESTED(ftrace_caller, PT_SIZE, ra)
        .globl _mcount
 _mcount:
        b       ftrace_stub
+#ifdef CONFIG_64BIT
+       nop
+#else
        addiu sp,sp,8
+#endif
 
        /* When tracing is activated, it calls ftrace_caller+8 (aka here) */
        lw      t1, function_trace_stop


Are you going to fix this for 3.9 release?


      reply	other threads:[~2013-04-02 11:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 23:43 Al Cooper
2013-01-17  6:27 ` Geert Uytterhoeven
2013-01-17 14:58   ` Alan Cooper
2013-01-17 15:35     ` Steven Rostedt
2013-04-02 11:12       ` Wladislav Wiebe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20130402T131118-818@post.gmane.org \
    --to=wladislav.kw@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®