From: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdrom.c: Only read a cdrom_msf0 struct from userspace.
Date: Thu, 27 Mar 2014 19:48:46 +0000 (UTC) [thread overview]
Message-ID: <loom.20140327T204517-831@post.gmane.org> (raw)
In-Reply-To: <1392472391-22429-1-git-send-email-Reimar.Doeffinger@gmx.de>
Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> That is all that is actually used, reading more just
> makes the code confusing.
> In addition also fix the header and separate documentation
> to correctly indicate which struct is expected as input.
>
> Maybe these inconsistencies were on purpose at some point
> with the intention to improve the IOCTL interface, but
> the code has now been unchanged for years and changing
> it would break e.g. MPlayer which fills the second half
> of the cdrom_msf struck with garbage, so I believe
> that at this point it is best commit to current behaviour
> and make the whole documentation less confusing.
ping
Having one piece of documentation that is clearly utter nonsense and then a
second piece of documentation that adds a note that the first documentation
is wrong sure isn't the way to keep things.
next prev parent reply other threads:[~2014-03-27 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 13:53 Reimar Döffinger
2014-03-27 19:48 ` Reimar Döffinger [this message]
2014-04-19 10:13 ` Reimar Döffinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20140327T204517-831@post.gmane.org \
--to=reimar.doeffinger@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®